search

ContinuumIO / topik

A Topic Modeling toolbox
BSD 3-Clause "New" or "Revised" License
92 stars 24 forks source link

fixed pyLDAvis ValidationError #42

Closed youngblood closed 9 years ago

youngblood commented 9 years ago

fixes #34

msarahan commented 9 years ago

Reed, this might silence the error, but could you add a note that says why it works? Or why it's necessary? This kind of argument in the code needs a comment, or else it costs people more time in the future to investigate why it is what it is.

youngblood commented 9 years ago

You're absolutely right, I just pushed another commit with a comment explaining.

Thanks,

Reed Youngblood Jr. Data Scientist

http://continuum.io/

On Oct 12, 2015, at 1:14 PM, Mike Sarahan notifications@github.com wrote:

Reed, this might silence the error, but could you add a note that says why it works? Or why it's necessary? This kind of argument in the code needs a comment, or else it costs people more time in the future to investigate why it is what it is.

— Reply to this email directly or view it on GitHub https://github.com/ContinuumIO/topik/pull/42#issuecomment-147480092.

msarahan commented 9 years ago

Perfect, thanks!