search

ContractLand / terra-bridge-contracts

GNU General Public License v3.0
1 stars 1 forks source link

Add topUp to HomeBridge #19

Closed marekkirejczyk closed 5 years ago

ghost commented 5 years ago

What is this feature for?

marekkirejczyk commented 5 years ago

Initially, when we deploy the bridge, all the ERC20 tokens are on the foreign chain. That means that the whole supply of home native should be on the balance of the home bridge. We need to have a way to initialize HomeBridge and transfer all native tokens to its balance.

I think it is the best and easiest way. We thought to allocate it in genesis block, but that is super tricky. Let me know if there is another/better way.

ghost commented 5 years ago

We can just send tokens into the bridge contracts (this is currently how it is done in the deployment script setup). I don't think it is necessary for the bridge contracts to know of where the tokens are coming from or have validations on it.

cehali commented 5 years ago

Hi,

I would like to reactivate discussion on this. This is not about tokens, but about native "ether" on the home network. Currently, they are not sent in deployment script (only ERC20 tokens are). This is required to properly set up a production bridge.

We tested all scenarios and in fact, there is an issue in this PR with onlyOwner and we will issue a new one today.

Marek

ghost commented 5 years ago

closing this one out since we have #21 .