Contrast-Security-OSS / cassandra-migration

Database migration (evolution) tool for Apache Cassandra
Apache License 2.0
107 stars 51 forks source link

Missing OSGi bundle LocationScanner #10

Open AVP505 opened 8 years ago

AVP505 commented 8 years ago

There is no "bundle" location scanner, only a FileSystemClassPathLocationScanner and JarFileClassPathLocationScanner.

Proposal create a bundle location scanner. Update ClassPathScanner.java, method createLocationScanner: if("bundle".equals(protocol)){ ...

Creating a patch for submission

SteveFeldman commented 8 years ago

Just doing a little housekeeping on our open issues. Did you ever submit a PR @AVP505?

AVP505 commented 8 years ago

@SteveFeldman , No I didn't submit any PR. But we looked to add the flyway osgi scanner, which worked after some tries. But my changes are a bit to specific for my problem to be a good general fix.

Flyway Osgi scanner: https://github.com/flyway/flyway/blob/54181cca3f3be603b8bc75769748198121abeb93/flyway-core/src/main/java/org/flywaydb/core/internal/util/scanner/classpath/OsgiClassPathLocationScanner.java