Add Travis Support - Githubissues

Contravariance / website

https://contravariance.rocks/

MIT License

4 stars 0 forks source link

Add Travis Support #20

Closed terhechte closed 5 years ago

terhechte commented 5 years ago

Currently, this checks the following properties:

Is the feed.rss properly formatted
Do the mp3 file / image file / show notes file exist
Is the mp3 / image / show notes file not empty
Do we have content / show notes (per item)
Do we have a summary (per item)
Do we have a properly formatted duration
Is the duration > 0 minutes

This will also only deploy to the server if the test is successful. For that, it replaces the current git webhook. Once this PR is merged, we should disable the webhook.

Fixes #13

BasThomas commented 5 years ago

Also, although definitely not blocking, we might want to add some tests for the script if possible? :)

terhechte commented 5 years ago

Awesome 🤩

Should we add another check to see if the mp3 file in the feed exists, too?

What do you mean by that?

terhechte commented 5 years ago

Also, although definitely not blocking, we might want to add some tests for the script if possible? :)

Yeah, I thought about that. Fundamentally it would be great to have this written in Swift and part of masse. But.. There's no standards compliant RSS parser for Swift that we could integrate.. and.. I'm not gonna write that :) So I'm a bit unsure how to best test this

BasThomas commented 5 years ago

Should we add another check to see if the mp3 file in the feed exists, too?

What do you mean by that?

Ah, what I meant was to check if the mp3 files from the rss feed also exist in the /entries folder of the repository. It happened in one episode where we updated the mp3's title but not the one in the RSS feed, causing the file not to be found.