ContriHUB / 202020-Eyesafe-Project

A python project which can be used to safeguard our eyes by making us watch 20m away for 20s each 20min
Apache License 2.0
0 stars 0 forks source link

making the python script as windows executable file #6

Closed Jaggi037 closed 1 year ago

Jaggi037 commented 1 year ago

Description

created a run.bat file for windows users in a separate directory named windows_executable, windows users can simply run that file and use the service without worrying about any dependencies.

Fixes # (issue)

Type of change

Motivation and Context

i think, windows users after downloading the script may need to find out the dependencies which are required to run this script but after this change they don't have to worry about anything they just need to run a single file and everything will be done for them.

How Has This Been Tested?

Checklist:

Test Configuration:

PriyavKaneria commented 1 year ago

Any updates on the suggestions? @Jaggi037

Jaggi037 commented 1 year ago

hey @PriyavKaneria, the "20-20-20-Eyesafe-project.exe" file is inside the dist folder of the zip file which i had attached at the end of the submitted PR. i checked and verified that the windows executable file which is "20-20-20-Eyesafe-project.exe" file is supported by all windows users irrespective of their systems, means you can make a release of this file as a software for windows. build_output.zip

here i re-uploaded that "build_output.zip" file

PriyavKaneria commented 1 year ago

Got it. Can you make the change in function definition regarding the pass keyword mentioned in review. Once done I can merge it

Jaggi037 commented 1 year ago

hey @PriyavKaneria i dont think any function in this script needs pass keyword as no function has empty code blocks, can you please clarify your concern?

PriyavKaneria commented 1 year ago

Fixes #1