search

ContriHUB / CP-Grind

0 stars 6 forks source link

Master #13

Open INam1995 opened 9 months ago

INam1995 commented 9 months ago

Styling of login page is fixed and now it is responsive .

i have made the page responsive by adding two media queries(1048 and 884 (one is given there already) ) changed background image , fixed minor styling issues , linked login.css , partial.css and login.js files properly with login.html file , linked properly signup right image and sign in left image , changed fonts style , fonts weight and improved overall appearance of the login page

Type of change

Motivation and Context

for better user experience and better appearance of login page in any view(like at mobile phone , at desktop ) i have required some styling changes and this problem solved the appearance of login page and responsiveness of the login page at any device.

How Has This Been Tested?

by opening live server and for media queries i inspected the web page and then check it.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Screenshots (if appropriate):

https://drive.google.com/drive/folders/1IMdc7D9AHNHB2y6hd_IEWV8-I_iIqCVr?usp=sharing

Checklist:

dhanrajchaurasia commented 9 months ago

You shouldn't change the colors of the login/signup card just fix the stylings (indentation, fontsize.etc) also make it responsive. I have seen the shared screenshots but they're not what I was expecting so just fix margin, spacing.etc and other styling mentioned above. Also in responsiveness, it should not switch between signup-login like that though it should get replaced completely to the other form (login becomes signup and signup becomes login) without the side banner/image in the responsive styling (for mobile devices).

INam1995 commented 9 months ago

Sir, can I made these changes now??

On Mon, 16 Oct, 2023, 4:04 pm Dhanraj Chaurasia, @.***> wrote:

You shouldn't change the colors of the login/signup card just fix the stylings (indentation, fontsize.etc) also make it responsive. I have seen the shared screenshots but they're not what I was expecting so just fix margin, spacing.etc and other styling mentioned above. Also in responsiveness, it should not switch between signup-login like that though it should get replaced completely to the other form (login becomes signup and signup becomes login) without the side banner/image in the responsive styling (for mobile devices).

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/CP-Grind/pull/13#issuecomment-1764186770, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6J2ULEFWYEPU4DVL4AGHYLX7UEVBAVCNFSM6AAAAAA6BY3WT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUGE4DMNZXGA . You are receiving this because you authored the thread.Message ID: @.***>

dhanrajchaurasia commented 8 months ago

@INam1995 yes! make an assignment request first!