Made the login/signup page responsive

Manan-Arora31 commented 9 months ago

Description

Made the login and signup page responsive . And corrected the bugs in the frontend .

Related Issue

Fixes #3 (issue)

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Motivation and Context

It is required as the webpage is not responsive so won't work in mobile devices.

How Has This Been Tested?

It has been tested by running on my local system.

Screenshots (if appropriate):

Checklist:

[x] I have registered myself at Contrihub website.
[ ] My code follows the code style of this project.
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Manan-Arora31 commented 9 months ago

@dhanrajchaurasia I have made the PR . Please check if any changes are required . I am not able to submit the PR on contrihub since it is not visible in my profile .

dhanrajchaurasia commented 9 months ago

@dhanrajchaurasia I have made the PR . Please check if any changes are required . I am not able to submit the PR on contrihub since it is not visible in my profile .

well you won't be awarded points if you don't see this issue as assigned in your profile page.

@shank03 can you fix this problem?

Manan-Arora31 commented 9 months ago

@dhanrajchaurasia Sir what should I do now ? There could be some glitch . Could you pls assign the issue to me again maybe then it will show on my contrihub profile .

dhanrajchaurasia commented 9 months ago

@dhanrajchaurasia Sir what should I do now ? There could be some glitch . Could you pls assign the issue to me again maybe then it will show on my contrihub profile .

okay make another request if you can I will accept that

Manan-Arora31 commented 9 months ago

@dhanrajchaurasia Sir I have requested the issue again on contrihub . Please assign it to me again

Manan-Arora31 commented 9 months ago

@dhanrajchaurasia Sir I have submitted the PR on contrihub . Please check

Manan-Arora31 commented 9 months ago

@dhanrajchaurasia Sir I have implemented the feature . Please check if anything else needs to be done .

dhanrajchaurasia commented 9 months ago

@Manan-Arora31 what actually did you do? increased the font size? is it responsive? side images are overflowing!

Screenshot from 2023-10-25 22-48-15

Manan-Arora31 commented 9 months ago

@dhanrajchaurasia Sir I have fixed the bugs in the responsive design . Please check now .

Manan-Arora31 commented 9 months ago

@dhanrajchaurasia Please check if any other changes needs to be done .

dhanrajchaurasia commented 8 months ago

Well @Manan-Arora31 I reviewed the PR, not satisfied with your work (you are doing the same stuff again and again without reading my instructions!)!

Manan-Arora31 commented 8 months ago

@dhanrajchaurasia Sir I was ready to work on the issue so was constantly asking again and again for any improvements . I changed what I undertood should be done, as mentioned in the change I had made the image responsive . If there were further changes required you could have said so

ContriHUB / CP-Grind