search

ContriHUB / Concise

The Moviepedia
0 stars 16 forks source link

Implemented Lazy Loading #25

Closed pranavi79 closed 3 years ago

pranavi79 commented 3 years ago

Fixes issue #7

pranavi79 commented 3 years ago

I implemented maxpages, because in absence of that currentPage+1 was being loaded for each page, I didn't notice the flaw with this logic, Let me make the required changes, is it okay if I submit by Monday ?

harshjoeyit commented 3 years ago

Hi Pranavi, You can submit it by Monday but I think the benefit of hactoberfest-accpeted PR will be valid till today only. Please confirm this with Kshitij Srivastava (Final Year CSE).

On Sat, 30 Oct 2021 at 05:55, Pranavi @.***> wrote:

I implemented maxpages, because in absence of that currentPage+1 was being loaded for each page, I didn't notice the flaw with this logic, Let me make the required changes, is it okay if I submit by Monday ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Concise/pull/25#issuecomment-955112322, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALB46T6QPON2BRVHPGBUC5DUJM3PZANCNFSM5GXB3S2Q .

--

Regards, Harshit

harshjoeyit commented 3 years ago

Seems to be working fine now. Good job @pranavi79 !

pranavi79 commented 3 years ago

Thank you so much!

harshjoeyit commented 3 years ago

👍

On Mon, 1 Nov 2021 at 19:46, Pranavi @.***> wrote:

Thank you so much!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Concise/pull/25#issuecomment-956271996, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALB46T4BWRPIAWD3GAPTYJLUJ2OKZANCNFSM5GXB3S2Q .

--

Regards, Harshit