search

ContriHUB / ContriHub-18

http://contrihubs.herokuapp.com - :snowman: :cyclone: ContriHub is an event under Avishkar-18 where we are expecting to get more and more people involved in Opens Source activities.
7 stars 33 forks source link

separate js from html code #18

Closed deepak-bharti-deel closed 6 years ago

deepak-bharti-deel commented 6 years ago

You have to simply make a new js file and put the js code on any one html page to this new js file and then include that js file in html file. e.g Projects/templates/Projects/home.html has some js at bottom. put it in a different js file and include it in bottom again.

You have to do this just for any one html page. Mention the name of html page while making prs?

deepak-bharti-deel commented 6 years ago

name js files accordingly.

XtheWiz commented 6 years ago

Can I take this issue ? @dbads

deepak-bharti-deel commented 6 years ago

@XtheWiz okay you have been assigned this issue. after creating pr on GitHub also create a request on https://contrihubs.herokuapp.com for achieving points. :smile:

zilehuda commented 6 years ago

taking this one (Y)

deepak-bharti-deel commented 6 years ago

@XtheWiz before starting mention the page name too and @zilehuda you can not work on same page as @XtheWiz

deepak-bharti-deel commented 6 years ago

@zilehuda choose a different page from @XtheWiz :smile:

zilehuda commented 6 years ago

okay @dbads

zilehuda commented 6 years ago

@dbads I am working on project module

deepak-bharti-deel commented 6 years ago

@zilehuda It's an easy issue. You need not to do it for all pages in project module. Its for learning purpose so we want to make sure that most of the new comers could get something to contribute. So whatever page you work on just mention here to avoid collision with others. :smile:

On Tue, Oct 9, 2018 at 10:28 AM zilehuda notifications@github.com wrote:

@dbads https://github.com/dbads I am working on project module

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/ContriHub-18/issues/18#issuecomment-428059794, or mute the thread https://github.com/notifications/unsubscribe-auth/AP3c4-9cV3FnOIc4ujc6ygHNzL3knDYuks5ujCzggaJpZM4XQqZB .

-- regards, Deepak Bharti http://deepakbharti.tech B.Tech CSE MNNIT Allahabad

XtheWiz commented 6 years ago

@dbads May I work on profile page :)

deepak-bharti-deel commented 6 years ago

@XtheWiz yeah sure :+1:

deepak-bharti-deel commented 6 years ago

Now @zilehuda you should choose a page except profile page :smile:

zilehuda commented 6 years ago

@dbads project module :)

debodirno commented 6 years ago

@dbads will work on home.html

deepak-bharti-deel commented 6 years ago

@debodirno @zilehuda of course you can work if it's not already done by someone else :smile: