search

ContriHUB / ContriHub-18

http://contrihubs.herokuapp.com - :snowman: :cyclone: ContriHub is an event under Avishkar-18 where we are expecting to get more and more people involved in Opens Source activities.
7 stars 33 forks source link

#35 Pagination implemented on leaderboard and home page #45

Closed ashwini571 closed 6 years ago

deepak-bharti-deel commented 6 years ago

There are some changes which aren't relevant to issue #35 According this issue only leaderboard.html and Projects/views.py/leaderboard definition should have modified. Fix this and reopen this PR.

deepak-bharti-deel commented 6 years ago

Rejected the PR. There are some bugs in ui. when user is on some mid page the link to first and last page is not visible. Fix this and reopen PR.

deepak-bharti-deel commented 6 years ago

When we paginate users on leaderboard on each page users are ordered as 1 to 10 try to fix this too :smile: extra points for this.

ashwini571 commented 6 years ago

But sir the links are working quite well in my localhost still i will do some refactor and will try to solve the ranking problem too

On Thu, Oct 11, 2018, 3:34 PM Deepak Bharti notifications@github.com wrote:

When we paginate users on leaderboard on each page users are ordered as 1 to 10 try to fix this too 😄 extra points for this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428897700, or mute the thread https://github.com/notifications/unsubscribe-auth/AkJnglblzdE51CnsL1ExOZSWuhNng5zOks5ujxexgaJpZM4XWQU2 .

deepak-bharti-deel commented 6 years ago

Yes next and previous buttons are working but link to first and last page isn't visible? also its not mobile friendly.

On Thu, Oct 11, 2018 at 4:10 PM ashwini571 notifications@github.com wrote:

But sir the links are working quite well in my localhost still i will do some refactor and will try to solve the ranking problem too

On Thu, Oct 11, 2018, 3:34 PM Deepak Bharti notifications@github.com wrote:

When we paginate users on leaderboard on each page users are ordered as 1 to 10 try to fix this too 😄 extra points for this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428897700>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AkJnglblzdE51CnsL1ExOZSWuhNng5zOks5ujxexgaJpZM4XWQU2

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428907877, or mute the thread https://github.com/notifications/unsubscribe-auth/AP3c45thKeFG0QGcV0IIIN22RUkkTe2Oks5ujyAXgaJpZM4XWQU2 .

-- regards, Deepak Bharti http://deepakbharti.tech B.Tech CSE MNNIT Allahabad

ashwini571 commented 6 years ago

I'll try to solve this asap

On Thu, Oct 11, 2018, 4:21 PM Deepak Bharti notifications@github.com wrote:

Yes next and previous buttons are working but link to first and last page isn't visible? also its not mobile friendly.

On Thu, Oct 11, 2018 at 4:10 PM ashwini571 notifications@github.com wrote:

But sir the links are working quite well in my localhost still i will do some refactor and will try to solve the ranking problem too

On Thu, Oct 11, 2018, 3:34 PM Deepak Bharti notifications@github.com wrote:

When we paginate users on leaderboard on each page users are ordered as 1 to 10 try to fix this too 😄 extra points for this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428897700 , or mute the thread <

https://github.com/notifications/unsubscribe-auth/AkJnglblzdE51CnsL1ExOZSWuhNng5zOks5ujxexgaJpZM4XWQU2

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428907877>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AP3c45thKeFG0QGcV0IIIN22RUkkTe2Oks5ujyAXgaJpZM4XWQU2

.

-- regards, Deepak Bharti http://deepakbharti.tech B.Tech CSE MNNIT Allahabad

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428910520, or mute the thread https://github.com/notifications/unsubscribe-auth/AkJngoaMqZtQRii4pieEnVE7L5wSV8uQks5ujyKWgaJpZM4XWQU2 .

deepak-bharti-deel commented 6 years ago

👍

On Thu, Oct 11, 2018 at 4:22 PM ashwini571 notifications@github.com wrote:

I'll try to solve this asap

On Thu, Oct 11, 2018, 4:21 PM Deepak Bharti notifications@github.com wrote:

Yes next and previous buttons are working but link to first and last page isn't visible? also its not mobile friendly.

On Thu, Oct 11, 2018 at 4:10 PM ashwini571 notifications@github.com wrote:

But sir the links are working quite well in my localhost still i will do some refactor and will try to solve the ranking problem too

On Thu, Oct 11, 2018, 3:34 PM Deepak Bharti notifications@github.com wrote:

When we paginate users on leaderboard on each page users are ordered as 1 to 10 try to fix this too 😄 extra points for this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428897700 ,

or mute the thread <

https://github.com/notifications/unsubscribe-auth/AkJnglblzdE51CnsL1ExOZSWuhNng5zOks5ujxexgaJpZM4XWQU2

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428907877 , or mute the thread <

https://github.com/notifications/unsubscribe-auth/AP3c45thKeFG0QGcV0IIIN22RUkkTe2Oks5ujyAXgaJpZM4XWQU2

.

-- regards, Deepak Bharti http://deepakbharti.tech B.Tech CSE MNNIT Allahabad

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428910520>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AkJngoaMqZtQRii4pieEnVE7L5wSV8uQks5ujyKWgaJpZM4XWQU2

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/ContriHub-18/pull/45#issuecomment-428910838, or mute the thread https://github.com/notifications/unsubscribe-auth/AP3c46DxiWrxpe3oG6UzncMawWHNzShUks5ujyLjgaJpZM4XWQU2 .

-- regards, Deepak Bharti http://deepakbharti.tech B.Tech CSE MNNIT Allahabad