ContriHUB / E-CP

A CLI tool with a variety of features to help in practicing competitive programming problems
0 stars 14 forks source link

Added a proxy functionality to the project. #22

Closed ashutoshsuthar2020 closed 1 year ago

ashutoshsuthar2020 commented 1 year ago

Have made necessary changes, Config.py is used to set and remove proxy while scrapper.py fetches the proxy for the program.

akstron commented 1 year ago

I don't see any implementation of proxy setup. You are just updating proxy in the config.json file. Let me know if there are other updates.

ashutoshsuthar2020 commented 1 year ago

sir i made a get_proxy function in scrapper.py (as you asked me to) to retrieve proxy from the config file. and the problem is retrieved from codeforces URL from CFScrapper.py

I have tested the commands and they work properly, on removing proxy-settings from my pc

ashutoshsuthar2020 commented 1 year ago

Sir i have made the suggested changes, can u check it now

ashutoshsuthar2020 commented 1 year ago

sir how do i merge my repo to master, I am deleting my repo every time someone makes some change to get to the latest version of master repo.

akstron commented 1 year ago

Your code doesn't allow users to access net without proxy (when users does not wants to use proxy, i.e., when proxy is unset). Kindly make changes accordingly.

akstron commented 1 year ago

Are you still facing problem in merging the master repo?

ashutoshsuthar2020 commented 1 year ago
akstron commented 1 year ago

Kindly merge the current main branch to this branch and push your changes

akstron commented 1 year ago

Let me know your ms teams id.

ashutoshsuthar2020 commented 1 year ago

ashutosh.20205048@mnnit.ac.in