search

ContriHUB / Easy2Do

An android app using Java and XML for boosting productivity. It has three modules to beat procrastination for tiny tasks, making habits easily, and getting important daily tasks done. Soon will try to add more of such features once these all work fine! The app is a work in progress, and contributions are welcome!
0 stars 3 forks source link

splash screen added and ui updated and timer bug fixed #6

Closed Crisonel closed 4 days ago

Crisonel commented 5 days ago

Description

Added a new activity for splash screen and new xml file used handler in SplashActivity.java to make the splash screen last long for 2 sec and then move to mainactivity theme updated new appealing colors both for light and dark mode added the ui of toolbar for switching theme(only ui) transition added to fragment change animation added to button for showing click

FIXED BUG OF TIMER - earlier if timer is working and you click it starts flickering resolved it and made the timer for 2 minutes

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related Issue

FIXED BUG OF TIMER - earlier if timer is working and you click it starts flickering resolved it and made the timer for 2 minutes

Fixes # (issue)#1 (issue)#5 (issue)#2

Type of change

Motivation and Context

The addition of splash screen makes the user experience better and new theme added

How Has This Been Tested?

since the app is small i added the feature and ran the app in a physical device of Android version 12

Screenshots (if appropriate):

splash screen WhatsApp Image 2024-10-11 at 1 13 11 PM

dark mode: 1000023234 1000023236

light mode: 1000023231

toolbar menu:(only ui currently not functional) 1000023230

Checklist:

Test Configuration:

mukul-dev commented 5 days ago

@Crisonel Great use of "Handler.postDelayed" for the delay! However, consider using other possible methods for implementing this feature like you can create a different activity set it as entry point of app and then move to the MainActivity. Also setting theme inside oncreate() method may cause flickering... I tested this code in two phones natively and results were quite different, and I tried adding delay of 3 seconds, 5 seconds or so but it was not reflected upon running... so now you try to solve these issues! Also, you can check out more resources for adding basic animations for logo (a simple zoom in/ zoom out), anything you like about it... for some bonus points too... Overall, I appreciate your work, but it could be better... you have time left still, so you can get back with a better solution!

Crisonel commented 5 days ago

@mukul-dev Please check my PR for issue 1 and 5 for github

mukul-dev commented 5 days ago

@mukul-dev Please check my PR for issue 1 and 5 for github

Yes i reviewed and accepted for the first issue! The second is regarding UI so its still opened as it can be improved.. few things that i viewed as of now is ... The Tab bar on the top of fragments is not uniform in the two implemented fragments in one of them is centred and in other its at bottom (the text specifically) so that need to be improved.. in the calendar selected date is circled dark purple and text is dark too so you can try out experimentally with more appealing color combinations!

Crisonel commented 4 days ago

@mukul-dev Please check my PR for issue 1 and 5 for github

Yes i reviewed and accepted for the first issue! The second is regarding UI so its still opened as it can be improved.. few things that i viewed as of now is ... The Tab bar on the top of fragments is not uniform in the two implemented fragments in one of them is centred and in other its at bottom (the text specifically) so that need to be improved.. in the calendar selected date is circled dark purple and text is dark too so you can try out experimentally with more appealing color combinations!

@mukul-dev i have changed the color scheme for light mode added a toolbar menu for changing theme (only ui) fixed the timer bug earlier if you press start while the timer is running it would flicker now it does not flicker and timer runs smoothly, also now it runs for 2 min. adjusted the toolbar text and height problem instead of creating it in each fragment i created it in activitiy_main.xml and updating it with the java code

Please review my PR for issue (issue)#5 as well as (issue)#2 and the timer bug that i resolved

mukul-dev commented 4 days ago

@mukul-dev i have changed the color scheme for light mode added a toolbar menu for changing theme (only ui) fixed the timer bug earlier if you press start while the timer is running it would flicker now it does not flicker and timer runs smoothly, also now it runs for 2 min. adjusted the toolbar text and height problem instead of creating it in each fragment i created it in activitiy_main.xml and updating it with the java code

Please review my PR for issue (issue)#5 as well as (issue)#2 and the timer bug that i resolved

The UI is much better, 2 min Timer also is working good (it has something that will be raised as a new issue but for now its working as expected!), Smartly set the toolbar too text too, I am merging this!

Can you mention what changes do we see upon clicking Light mode/ dark mode in the menu so that i can review and raise issue (if any) afterwards..

Crisonel commented 4 days ago

@mukul-dev I didn't get the time to make them functional and it was also not required in issue it was optional feature. Currently they do not function

Objective is to If you click on light mode theme will be changed to light And if you click on dark mode so it changes to dark theme.

mukul-dev commented 4 days ago

Yes, it was optional! Make a PR regarding the bug #2 on the portal so that it can be closed, and points can be allotted. Keep up the good work 👍