search

ContriHUB / Jodi-Makers

1 stars 24 forks source link

Change the name in the logo #21

Closed akshatvermavi closed 1 year ago

akshatvermavi commented 1 year ago

Throughout all the pages wherever you find the name tinder replace it with the name Jodi-Makers is now done. Now owners and users can enjoy with new logo of Jodi-Makers Jodi-Makers

admirerr commented 1 year ago

Throughout all the pages wherever you find the name tinder replace it with the name Jodi-Makers is now done. Now owners and users can enjoy with new logo of Jodi-Makers Jodi-Makers

Screenshot 2023-10-12 at 11 53 56 AM

@akshatvermavi Make the logo transparent. Try to remove this black box.

akshatvermavi commented 1 year ago

Sir Now you can see the changes and suggest me if any changes are require Jodi-Makers

admirerr commented 1 year ago

Sir Now you can see the changes and suggest me if any changes are require Jodi-Makers

Try to remove these watermark and then integrate this image in the code.

akshatvermavi commented 1 year ago

[image: sodapdf-converted(1).png] Hii sir sorry for the late reply now it ready so I am going to replace it

On Thu, Oct 12, 2023 at 10:42 PM Shubham Kashyap @.***> wrote:

Sir Now you can see the changes and suggest me if any changes are require [image: Jodi-Makers] https://user-images.githubusercontent.com/99114167/274508989-be227f3d-55f7-410c-914d-59043f44ae6e.png

Try to remove these watermark and then integrate this image in the code.

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Jodi-Makers/pull/21#issuecomment-1760029705, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUFZN2IJWP3GB3IVWAROSLX7AQGNANCNFSM6AAAAAA55CNE3E . You are receiving this because you were mentioned.Message ID: @.***>

akshatvermavi commented 1 year ago

Sir now you can changes and approve my request Branch Link https://github.com/akshatvermavi/Jodi-Makers/tree/test2

On Sun, Oct 15, 2023 at 12:19 AM Akshat Verma @.***> wrote:

[image: sodapdf-converted(1).png] Hii sir sorry for the late reply now it ready so I am going to replace it

On Thu, Oct 12, 2023 at 10:42 PM Shubham Kashyap @.***> wrote:

Sir Now you can see the changes and suggest me if any changes are require [image: Jodi-Makers] https://user-images.githubusercontent.com/99114167/274508989-be227f3d-55f7-410c-914d-59043f44ae6e.png

Try to remove these watermark and then integrate this image in the code.

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Jodi-Makers/pull/21#issuecomment-1760029705, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUFZN2IJWP3GB3IVWAROSLX7AQGNANCNFSM6AAAAAA55CNE3E . You are receiving this because you were mentioned.Message ID: @.***>

admirerr commented 1 year ago

@akshatvermavi Here are the few modifications that you are supposed to do

Push these commits.

akshatvermavi commented 1 year ago

Sir, i made the required changes of file name in the path i.e. Jodi-Makers.jpeg to Jodi-Makers.png So it's my humble request to you that please review my PR and merge it. Branch LINK https://github.com/akshatvermavi/Jodi-Makers/tree/test2

On Mon, Oct 16, 2023 at 10:40 AM Shubham Kashyap @.***> wrote:

@akshatvermavi https://github.com/akshatvermavi Here are the few modifications that you are supposed to do

  • Remove background of Jodi-Makers.png in client/src/images using some background remover tool and commit. Take care that image must not contain any watermark.
  • You have used the name Jodi-Makers.jpg in client/src/components/Nav.js. Update it to Jodi-Makers.png and commit.

Push these commits.

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Jodi-Makers/pull/21#issuecomment-1763735881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUFZN5XHQ36GHZOXN7YSL3X7S6S7ANCNFSM6AAAAAA55CNE3E . You are receiving this because you were mentioned.Message ID: @.***>

admirerr commented 1 year ago

4fb6282

@akshatvermavi You missed modification mentioned in point 1 i.e.- (Removal of background of image using some background removal tool).

akshatvermavi commented 1 year ago

Sir The background is already removed, its white will work. I am attaching the Image please comment it out.

On Tue, Oct 17, 2023 at 7:45 AM Shubham Kashyap @.***> wrote:

4fb6282 https://github.com/ContriHUB/Jodi-Makers/commit/4fb62825d1e72a4c50aef67af5b8c459cb54d383

@akshatvermavi https://github.com/akshatvermavi You missed modification mentioned in point 1 i.e.- (Removal of background of image using some background removal tool).

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Jodi-Makers/pull/21#issuecomment-1765547845, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUFZN2MZTG2PGMB336GOC3X7XS55AVCNFSM6AAAAAA55CNE3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVGU2DOOBUGU . You are receiving this because you were mentioned.Message ID: @.***>

admirerr commented 1 year ago

@akshatvermavi Raise a PR approval request on ContriHUB website.

akshatvermavi commented 1 year ago

Thank You sir, please update in the contrihub website for main issue and for some extra work for creation of logo also.

On Tue, Oct 17, 2023 at 4:49 PM Shubham Kashyap @.***> wrote:

@akshatvermavi https://github.com/akshatvermavi Raise a PR approval request on ContriHUB website.

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Jodi-Makers/pull/21#issuecomment-1766208572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXUFZN5W34ASGUETU4SX6MDX7ZSVZAVCNFSM6AAAAAA55CNE3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGIYDQNJXGI . You are receiving this because you were mentioned.Message ID: @.***>