ContriHUB / Just-Share

Android app that enables quick transfer of photos, videos, documents, and audio files using WiFiDirect and Bluetooth.

MIT License

0 stars 7 forks source link

Implement Theme for Dark Mode #1

Closed SaiDheerajPeketi closed 2 weeks ago

SaiDheerajPeketi commented 1 month ago

🚀Feature Request

Implementation of Theme for Dark Mode

Expected behavior

An aesthetic Dark Mode with a theme and drawables similar to the theme used in Light Mode.

Current behavior

Uses Default Dark Theme and some customised Theme colors in Dark Mode that don't go well with the App's Theme in Light Mode.

Step to reproduce

Turn Dark Mode On after running the application.

Possible Solution

Modify the Colors and Drawables being utilised when application is being used in dark mode.

Why is this feature important to you?

This feature give a sense of uniformity allowing the app to be usable in dark mode too.

ShivaniSaini123 commented 1 month ago

I am interested in doing this. Should I start?

ShivaniSaini123 commented 1 month ago

This project is in Kotlin, but I don't know the language. I am familiar with React and CSS. Can I still contribute to improving this project?

SaiDheerajPeketi commented 1 month ago

Yes, you can try learning it on the go, if you are interested.

aachintya commented 1 month ago

Hi @ShivaniSaini123 . How will you implement dark theme. I need to know because i am working on a follow up issue requires to know your implmentation.

ShivaniSaini123 commented 1 month ago

I don't know kotlin,but I implement before in react

On Thu, 10 Oct, 2024, 2:39 pm Aachintya, @.***> wrote:

Hi @ShivaniSaini123 https://github.com/ShivaniSaini123 . How will you implement dark theme. I need to know because i am working on a follow up issue requires to know your implmentation.

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Just-Share/issues/1#issuecomment-2404535121, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGHVSAKTRD5EN5OLABDBBWDZ2Y74TAVCNFSM6AAAAABPOB3SPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBUGUZTKMJSGE . You are receiving this because you were mentioned.Message ID: @.***>

aachintya commented 1 month ago

Ok i'll wait for 1 day

RITIK-CHAUDHRY commented 3 weeks ago

@SaiDheerajPeketi can you assign me this issue. i know kotlin

RITIK-CHAUDHRY commented 3 weeks ago

@SaiDheerajPeketi please add hacktoberfest label to this issue

RITIK-CHAUDHRY commented 3 weeks ago

@SaiDheerajPeketi please review my PR

SaiDheerajPeketi commented 3 weeks ago

I've added bonus for this issue, if you implement theme based icon