ContriHUB / MovieScreen

0 stars 14 forks source link

Add a 'Movie Details' Page #13

Closed eleensmathew closed 4 weeks ago

eleensmathew commented 1 month ago

Expected behavior

Add a page that allows users to read the movie description and title on their own, with a list of movies displayed on the movie_list page. When a user clicks on a movie title, they should be taken to a separate movie_details page where all the details of the selected movie, such as the title, description, release date, runtime (if available), are displayed. Additionally, the cast information should be fetched from the OMDb API, which is already used in the add_movie view, and displayed on the movie_details page in a clear format. The cast should be presented as a list, with each actor's name displayed on a new line. DON'T add movie ratings. image

Current behavior

Right now clicking on the movie in the movie_list doesn't take us to a new page. image

ShouryaMishra2006 commented 1 month ago

@eleensmathew please assign me this issue

eleensmathew commented 1 month ago

Hey Let me add this issue in COntrihub and you can request assignment there

samimshoaib01 commented 1 month ago

Please assign this issue if not assigned to anyone

Vaishnavi1047 commented 1 month ago

Screenshot 2024-10-12 192739 @eleensmathew whats the issue

eleensmathew commented 1 month ago

There isnt any issue

Vaishnavi1047 commented 1 month ago

@eleensmathew how to run it in ? i tried it is not running

eleensmathew commented 1 month ago

Check out the readme

Vaishnavi1047 commented 1 month ago

I read it but like the virtual environment we have to deactivate after we are done with out work?

eleensmathew commented 1 month ago

Yes we have to deactivate

Vaishnavi1047 commented 1 month ago

Screenshot 2024-10-12 205724 @eleensmathew ?

eleensmathew commented 1 month ago

The path is wrong

Vaishnavi1047 commented 1 month ago

it was giving in the running migration

Vaishnavi1047 commented 1 month ago

sry got it ,it worked

Vaishnavi1047 commented 1 month ago

Screenshot 2024-10-12 210543

eleensmathew commented 1 month ago

/user/shows/

Vaishnavi1047 commented 1 month ago

Screenshot 2024-10-12 211053 in these two pages i have to work on right?

eleensmathew commented 1 month ago

Yup

Vaishnavi1047 commented 1 month ago

and what u mean by show here ? like movie list me we have to add movies also on clicking the movie it should take us to detail page then we donot have any use of show here na?

eleensmathew commented 1 month ago

So in a movie theater, a movie can have multiple show times right? So when someone purchase a movie to ket multiple times of the show are available. Also for each show we need to track which all seats are bought.

Vaishnavi1047 commented 1 month ago

@eleensmathew i am not able to add the movies donot know why its saying to give email and enter password when i am going to /add_movies

eleensmathew commented 1 month ago

I think you should refer to the django documentation https://docs.djangoproject.com/en/5.1/

Vaishnavi1047 commented 1 month ago

can u specify which part of the documentation should i read to solve my problem

eleensmathew commented 1 month ago

I think since you are facing a lot of issues getting an overview of the entire documentation would help.

Vaishnavi1047 commented 1 month ago

hm okay mam as i am not enough comfortable in working it should be good thank you

Vaishnavi1047 commented 1 month ago

@eleensmathew can u provide the api key as it wasnot mention in the docs Screenshot 2024-10-12 225844

eleensmathew commented 1 month ago

You will have to create your own :)

Vaishnavi1047 commented 1 month ago

Screenshot 2024-10-13 003648 is it fine the list page ?

Vaishnavi1047 commented 1 month ago

Screenshot 2024-10-13 004818 i am taking the ref from { "Search": [ { "Title": "Maverick and Ariel's First Ever Ever Movie Hollywood or Else... (Ang pinakamahabang title ng movie sa balat ng lupa)", "Year": "2010", "imdbID": "tt1204784", "Type": "movie", "Poster": "N/A" }, { "Title": "The Movie Title", "Year": "2017", "imdbID": "tt6730584", "Type": "movie", "Poster": "https://m.media-amazon.com/images/M/MV5BNTNiOWJjMjYtYWFlYS00OGFkLTlhMDktNjQ5ZGViYTYyMTY4XkEyXkFqcGdeQXVyNTkyNjA2MTQ@._V1_SX300.jpg" }, { "Title": "What Is This Movie that Ian Is so Excited About It Makes No Sense Whatsoever and There Is No Way It's Going to Be Made without Him Knowing It - Da Best Title Ever Btw:) : The Movie", "Year": "2020", "imdbID": "tt14290026", "Type": "movie", "Poster": "https://m.media-amazon.com/images/M/MV5BNDMyNjlkOGEtOWFhZS00ZTlmLWJkNDQtNzQ3YjQ1ZTI5ZTg4XkEyXkFqcGc@._V1_SX300.jpg" } ], "totalResults": "3", "Response": "True" } api call

Vaishnavi1047 commented 1 month ago

@eleensmathew Screenshot 2024-10-13 011903 as in this api no cast is there so what to do i am using this information only in movie details mam

eleensmathew commented 1 month ago

Screenshot 2024-10-13 003648

is it fine the list page ?

Looks good but why have you changed the movie list page?

eleensmathew commented 1 month ago

@eleensmathew

Screenshot 2024-10-13 011903

as in this api no cast is there so what to do i am using this information only in movie details mam

Hmm have you tried reading ondb docs if they have a certain api for this? Else what you can do is find another api provider to get the info.

Vaishnavi1047 commented 1 month ago

@eleensmathew i have made the changes in model as per this now if searched for another api i have to again change the movies model

eleensmathew commented 1 month ago

Why does getting info from an api change your model? If you are done make a pr and I'll review your code and suggest changes.

Vaishnavi1047 commented 1 month ago

@eleensmathew as model donot have omdb value to make every movie a unique giving it a id so i have added that which ensures on clicking u are going to details of a particular movie only

eleensmathew commented 1 month ago

Hey check this out https://github.com/pshrmn/notes/blob/master/django/models.md

VishalMinj commented 1 month ago

Is this issue open right now?

eleensmathew commented 1 month ago

Taken up by someone currently

hexwhiz commented 1 month ago

@eleensmathew I have made the PR.