search

ContriHUB / MovieScreen

0 stars 13 forks source link

Implement login and sign up #18

Closed eleensmathew closed 1 week ago

eleensmathew commented 1 week ago

Expected behavior

Implement a login and sign up page for both users and admins. Add this page to the navbar if not signed in and add logout function if signed in.

Current behavior

Right now only admins can purchase tickets after admin login. This should be changed so that any logged in user can purchase a ticket.

VishalMinj commented 1 week ago

Please assign this issue

Rockyoudead8 commented 1 week ago

can you assign this issue to me as well

divyanshu-912 commented 1 week ago

Assign this ton me

eleensmathew commented 1 week ago

Already assigned via contrihub website.

VishalMinj commented 1 week ago

A few queries

eleensmathew commented 1 week ago

Yes and yes

VishalMinj commented 1 week ago

Sign up page for admin too?? Aren't admin accounts supposed to be created from the backend/terminal?

eleensmathew commented 1 week ago

No need for admin sign up

VishalMinj commented 1 week ago

Another thing is that the base class is User for both use and admin, so the admin can also use the user login page. So may be no dedicated page for admin, or do you want to restrict admin entering from regular login? Also can I toggle the design of navbar slightly?

eleensmathew commented 1 week ago

Dont restrict admin from regular admin. Feel free to toggle navbar design

VishalMinj commented 1 week ago

Hey @eleensmathew, here's preview image image image

VishalMinj commented 1 week ago

Also I don't see the url of ticket booking. There is the html for that and a url to carry the seat id I guess. But I don't see the url to open that page

VishalMinj commented 1 week ago

Add movie ain't working?

eleensmathew commented 1 week ago

Check urls.py for the url

eleensmathew commented 1 week ago

Add movie ain't working?

Its based on an api - omdb. As the api key in a .env file and it will work.

VishalMinj commented 1 week ago

Ticket booking to be accessed from movie list or from another button on navbar?

eleensmathew commented 1 week ago

From showlist

VishalMinj commented 1 week ago

Ticket booking seems to be working for regular user. What do you wish to implement in it?

eleensmathew commented 1 week ago

Nothing. If you have implemented the login and sign up as well as the html css changes feel free to raise pr

VishalMinj commented 1 week ago

oh, ok let me make some final checks