added stars for two types of reviews imdb and user - Githubissues

ContriHUB / MovieScreen

0 stars 13 forks source link

added stars for two types of reviews imdb and user #20

Open divyanshsingh101 opened 1 week ago

divyanshsingh101 commented 1 week ago

added a rating feature

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related Issue

Fixes # (issue)

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Motivation and Context

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Screenshots (if appropriate):

Screenshot 2024-10-12 162741 Screenshot 2024-10-12 162755 Screenshot 2024-10-12 162810

Checklist:

[ ] I have registered myself at Contrihub website.
[ ] My code follows the code style of this project.
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

eleensmathew commented 1 week ago

Hey can you resolve the conflicts?

eleensmathew commented 1 week ago

Attach screenshots with an example movie

divyanshsingh101 commented 1 week ago

added it

eleensmathew commented 1 week ago

Hey are you showing the average of all user ratings in the user ratings? If you are confused it must be like: 1 - imdb star rating 2 - avg user rratings 3 - user selects ratings Use these titles under the stars

divyanshsingh101 commented 1 week ago

no as there is no session as of now same user can add multiple rating so i need to take avg of all ratings then display the rating ? and should the add rating slider be on the same page ?

divyanshsingh101 commented 1 week ago

what is user selects rating ?

eleensmathew commented 1 week ago

no as there is no session as of now same user can add multiple rating so i need to take avg of all ratings then display the rating ? and should the add rating slider be on the same page ?

Yes and yes

eleensmathew commented 1 week ago

what is user selects rating ?

its basically the add ratings slider

divyanshsingh101 commented 1 week ago

how much time do i have as i have to change the features allot :( ?

eleensmathew commented 1 week ago

how much time do i have as i have to change the features allot :( ?

Just submit this pr in the website and take as much time as you need to complete it.

eleensmathew commented 6 days ago

Have you made the requested changes? If not close this pr

eleensmathew commented 5 days ago

Someone else has also fix this issue. I will pull her changes in the meantime you can update your code and overwrite the changes made by the other pr

divyanshsingh101 commented 5 days ago

Sorry ma'am I couldn't do the changes as I am hospitalized from 2 days as I have been diagnosed with dengue and typhoid

eleensmathew commented 5 days ago

Oh ok np. Hope you get well soon then.