added toggle feature with element color change dynamically

jatin31195 commented 1 month ago

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related Issue

Fixes #3

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Motivation and Context

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Screenshots (if appropriate):

Toggle function

Checklist:

[x ] I have registered myself at Contrihub website.
[x ] My code follows the code style of this project.
[ x] I have commented my code, particularly in hard-to-understand areas
[ x] My changes generate no new warnings
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x ] I have read the CONTRIBUTING document.
[ ] Any dependent changes have been merged and published in downstream modules
[ x] I have added tests to cover my changes.
[ x] All new and existing tests passed.

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

jatin31195 commented 1 month ago

@Codipk Please add Hacktoberfest label to this PR. if you need any more changes then let me know

Codipk commented 1 month ago

Hey Jatin, u can start working on this issue also the theme should have effect on password generator button , slider ,the purple colour box should be changed to light colour if it is a light theme and in dark it remains as it is .Complete this within 1 day and provide screenshot or video of your working.

jatin31195 commented 1 month ago

I have made the changes can u please look at it and describe me about it you need anything else i will do it yesterday i made it for 3 themes but today i got you mail regarding what new changes we have to made so i changed it accordingly look at it and let me know

On Tue, 8 Oct 2024 at 7:49 AM, Dipti Kumari @.***> wrote:

Hey Jatin, u can start working on this issue also the theme should have effect on password generator button , slider ,the purple colour box should be changed to light colour if it is a light theme and in dark it remains as it is .

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Password-Generator/pull/5#issuecomment-2398528668, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUBLFLVHNEIBM2XA6XHXTE3Z2M6MPAVCNFSM6AAAAABPQX7FDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJYGUZDQNRWHA . You are receiving this because you were assigned.Message ID: @.***>

Codipk commented 1 month ago

Change the copy icon colour also it is not visible in light mode

jatin31195 commented 1 month ago

Now completely fixed copy button i have used icon in place of image so that its color can change also added visual feedback on copy

On Wed, 9 Oct 2024 at 11:01 AM, Dipti Kumari @.***> wrote:

Change the copy icon colour also it is not visible in light mode

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Password-Generator/pull/5#issuecomment-2401350795, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUBLFLUJIPBEFJNBSYSAIETZ2S5UPAVCNFSM6AAAAABPQX7FDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGM2TANZZGU . You are receiving this because you were assigned.Message ID: @.***>

jatin31195 commented 1 month ago

Now check and let me know if anything else is needed

On Wed, 9 Oct 2024 at 11:40 AM, Jatin Rajput @.***> wrote:

Now completely fixed copy button i have used icon in place of image so that its color can change also added visual feedback on copy

On Wed, 9 Oct 2024 at 11:01 AM, Dipti Kumari @.***> wrote:

Change the copy icon colour also it is not visible in light mode

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Password-Generator/pull/5#issuecomment-2401350795, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUBLFLUJIPBEFJNBSYSAIETZ2S5UPAVCNFSM6AAAAABPQX7FDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGM2TANZZGU . You are receiving this because you were assigned.Message ID: @.***>

jatin31195 commented 1 month ago

Heyy my assignment request are still not updated although its merged i am not able to take any other request

On Wed, 9 Oct 2024 at 12:08 PM, Dipti Kumari @.***> wrote:

Merged #5 https://github.com/ContriHUB/Password-Generator/pull/5 into master.

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Password-Generator/pull/5#event-14566772368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUBLFLQBXRDMUPBL3Q3OCNLZ2TFPTAVCNFSM6AAAAABPQX7FDGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGU3DMNZXGIZTMOA . You are receiving this because you were assigned.Message ID: @.***>

ContriHUB / Password-Generator