Update security_system.py

Aqua-16 commented 1 year ago

Updated over the previous version.

Description

Loaded the model, specified the cascade paths, implemented the dictionary functions as well as function responsible for getting names. Used those functions to finish the rest of the work.

Fixes #5 : Updated the previous issues as follows:-

Fixed typos
Since model_path and cascade_path are optional arguments, they are only given a specified path if no arguments have been passed to them. This will allow the code to use user-define classifiers and models.

The following has been implemented in general:-

The authorized_persons.csv file is being read and stored in a dictionary as key : value pairs of Name and Authorization Status
The label_to_name.csv file is being read and stored in a dictionary as key : value pairs of Label and Name
get_person_name file has been implemented to return "Unknown" if confidence score is too low or the provided label is unavailable. Otherwise, it now returns the name associated with the label.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

I have tested this on Jupyter Labs as well as Command Terminal using a Virtual Environment. Each function has also been individually ran to test for any errors.

Checklist:

[x] I have registered myself at Contrihub website.
[x] My code follows the code style of this project.
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

sanskaromar commented 1 year ago

@Aqua-16 I'd appreciate it if the commit messages were clearer about what's being changed. There is no need to mention about #TODO there. And rename your PR to convention Fixes #(issue): Description.

Aqua-16 commented 1 year ago

Thank you for bringing this to my attention sir, I'll fix it right away

sanskaromar commented 1 year ago

Are you still working on this? Btw I would encourage a better commit message.

You can refer this resource on how to write better commit messages.

Aqua-16 commented 1 year ago

Yes Sir I was still working on it, but I think I'm done now. I have also updated the description to reflect my overall changes.

ContriHUB / SecureFace