search

ContriHUB / Sheher

Django project to get info regarding tourist places.
1 stars 19 forks source link

Removed unnecessary CSS from homepage #18

Closed DNA5769 closed 1 year ago

DNA5769 commented 1 year ago

Fixes #3

I first removed unnecessary CSS from the CSS present inside the <style> tag. I also moved some of the CSS present and converted it into bootstrap.

I also removed some unnecessary inline CSS

CyrilMishra commented 1 year ago

Fixes #3

I first removed unnecessary CSS from the CSS present inside the <style> tag. I also moved some of the CSS present and converted it into bootstrap.

I also removed some unnecessary inline CSS

Hi , DNA5769 You also have to remove the unnecessary from the css files in static folder, that are being used in Homepage(CSS only).

DNA5769 commented 1 year ago

Ok sir, I'll work on it

DNA5769 commented 1 year ago

Sir the thing is that the stylesheets present in the static folder, namely home.css and styles.css are used in many other pages as well. So I don't think I can remove any CSS looking at the homepage alone (since it might be used in other pages).

Also I think (correct me if I'm wrong) styles.css contains Bootstrap CSS, so I don't think removing any part of it is necessary.

DNA5769 commented 1 year ago

Hi , DNA5769 You also have to remove the unnecessary from the css files in static folder, that are being used in Homepage(CSS only).

Hello Sir, so I looked into it again and there is only one "css files in static folder, that are being used in Homepage" and that is styles.css. However styles.css consists Bootstrap code, and since it is a CSS framework which we are importing I dont see how removing unused parts of it, is necessary.

But if that's the task then just let me know and I will work on it.

CyrilMishra commented 1 year ago

Hi , DNA5769 You also have to remove the unnecessary from the css files in static folder, that are being used in Homepage(CSS only).

Hello Sir, so I looked into it again and there is only one "css files in static folder, that are being used in Homepage" and that is styles.css. However styles.css consists Bootstrap code, and since it is a CSS framework which we are importing I dont see how removing unused parts of it, is necessary.

But if that's the task then just let me know and I will work on it.

The task is to remove redundant css , see carefully there are two folders which consists styles.css , task is to merge that two styles.css . You just have to delete several unnecessary lines of code in css file.

DNA5769 commented 1 year ago

Oh ok, got it sir

DNA5769 commented 1 year ago

Hello Sir,

I tried merging the files you had mentioned assets/styles.css and css/styles.css but actually they were the same file as they had the same content.

So therefore I reduced the line count of css/styles.css from 11768 lines to 1415 lines by removing all the unnecessary CSS rules present in it.

css/styles.css was actually being used by 4 HTML files, namely

So I took all of them into consideration while removing the tags.

Also assets/styles.css isn't being used by any file, so I just let it be.

DNA5769 commented 1 year ago

Should I delete assets/styles.css ?

CyrilMishra commented 1 year ago

If it is not being used anywhere else then remove it.

On Sun, 9 Oct, 2022, 10:33 Dennis Thomas, @.***> wrote:

Should I delete assets/styles.css ?

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Sheher/pull/18#issuecomment-1272456381, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASKWN3UCGZKQHVFQIEYA3TLWCJG2NANCNFSM6AAAAAAQ6Z7WX4 . You are receiving this because you commented.Message ID: @.***>

DNA5769 commented 1 year ago

Done Sir