Closed eleensmathew closed 10 months ago
Just let me know if i should pull current changes and commit again.
Message for Invalid Credentials not working as expected.
This does not disappear
Ya the script tag on that html page is not getting loaded. I'm unable to figure out why. Invested a lot of time on it too. Would be helpful if you have any suggestions for the same
On Fri, 13 Oct 2023 at 19:47, Kunal Katiyar @.***> wrote:
Message for Invalid Credentials not working as expected.
[image: image] https://user-images.githubusercontent.com/59749539/274927188-b7e22f60-4137-4c41-ad63-3f55c9088a20.png
This does not disappear
— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Sheher/pull/77#issuecomment-1761600370, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWAG2HHSUCDBOHRT7VNGRCLX7FEQ5ANCNFSM6AAAAAA565TULE . You are receiving this because you authored the thread.Message ID: @.***>
You can add new script and style for specifically this message if existing one is not working on this one
Okay let me check that out.
On Fri, 13 Oct 2023 at 21:19, Kunal Katiyar @.***> wrote:
You can add new script and style for specifically this message if existing one is not working on this one
— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Sheher/pull/77#issuecomment-1761735429, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWAG2HB2I45WINTVWTLUYODX7FPHTANCNFSM6AAAAAA565TULE . You are receiving this because you authored the thread.Message ID: @.***>
Fixed the issue👍
Can you add same style to "Invalid Credentials" message too ?
How about now?
LGTM
Wait is there any issue?
No. That was a mistake from my end.
Made messages more consistent
Corrected the message after registering,invalid credentails and logging out. Unforu=tunately the javascript for invalid credentials is not getting loaded for some reason.
Related Issue
Fixes # (https://github.com/ContriHUB/Sheher/issues/60)