ContriHUB / Sheher

Django project to get info regarding tourist places.
1 stars 19 forks source link

Replace places #84

Open Manan-Arora31 opened 10 months ago

Manan-Arora31 commented 10 months ago

Description

Replaced places section with top places section and created separate all places page

Related Issue

Fixes #81 (issue)

Type of change

Motivation and Context

How Has This Been Tested?

It has been tested by running on my local system.

Screenshots (if appropriate):

Checklist:

Test Configuration:

Manan-Arora31 commented 10 months ago

@kunal2812 I have made the PR . Please review and tell if any changes needs to be done .

Manan-Arora31 commented 10 months ago

@kunal2812 Sir I have fetched the places for top places from review ratings model, so only the places which are rated will be visible.

Manan-Arora31 commented 10 months ago

Otherwise on what basis will we display the top places ?

kunal2812 commented 10 months ago

If we do not have enough rated places we can populate the "Top Places" section with places without ratings. The key point is that it should not be empty if we have places available.

Manan-Arora31 commented 10 months ago

@kunal2812 Should I make it same as the previous all places section in this case?

kunal2812 commented 10 months ago

Suppose there are 4 places - Place1: Rating 4, Place2: Rating 5, Place3: Not Rated, Place4: Not Rated.

So in the top section places the order should be - Place2 > Place1 > (Place3 = Place4)

Manan-Arora31 commented 10 months ago

Okay I will implement this

Manan-Arora31 commented 10 months ago

@kunal2812 I have made the required changes . Please see to it .

kunal2812 commented 10 months ago

image

Check the modal on "Home" page

image

This is your modal on "All Places" page

Fix it properly.

Manan-Arora31 commented 10 months ago

@kunal2812 I have corrected the modal . Please see it

Manan-Arora31 commented 10 months ago

@kunal2812 Sir I have implemented all the features now . Please check if anything else needs to be done .

kunal2812 commented 10 months ago

image

This functionality is not working in "All Places" page. Also make the cards in "All Places" page look like as they are in "Home" page. There is no weather information in the modal as well.

image

Uncomment these lines for weather info. Someone pushed without uncommenting them.

Manan-Arora31 commented 9 months ago

@kunal2812 Sir I have corrected the frontend of the cards and uncommented the lines . I tried hard to implement the functionality but couldn't do it .

kunal2812 commented 9 months ago

"Check Safety" functionality is already implemented. You just have to use it. Refer to "Home" page to see how it's done. Try to complete it.

Manan-Arora31 commented 9 months ago

@kunal2812 Sir I tried a lot to implement the functionality . But I am not able to do it.