search

ContriHUB / Upyogaarth

A utility application made using Flutter.
3 stars 17 forks source link

App icon #37

Closed ProgrammingPirates closed 2 years ago

ProgrammingPirates commented 2 years ago

please Accept my request

nisiddharth commented 2 years ago

This is related to issue #11

nisiddharth commented 2 years ago

Hello @ProgrammingPirates I cannot accept this PR as of now. There are few issues:

  1. You did not get this issue assigned to you from https://contrihub21.herokuapp.com/
  2. The changes you made do not change the App icon. You have just added a useless dart file to the project without even linking it anywhere. Also, the icon should be applied cross-platform and not just on Android.

For a demo on how ContriHUB works watch https://cutt.ly/CQ_brief_rec from time: 1:47:24.

I am closing this PR as of now, if you fix these, you can reopen it.

ProgrammingPirates commented 2 years ago

Ok sir i updated this file and again pr

On Sat, Oct 9, 2021, 9:57 AM Nishchal Siddharth Pandey < @.***> wrote:

Hello @ProgrammingPirates https://github.com/ProgrammingPirates I cannot accept this PR as of now. There are few issues:

  1. You did not get this issue assigned to you from https://contrihub21.herokuapp.com/
  2. The changes you made do not change the App icon. You have just added a useless dart file to the project without even linking it anywhere. Also, the icon should be applied cross-platform and not just on Android.

For a demo on how ContriHUB works watch https://cutt.ly/CQ_brief_rec from time: 1:47:24.

I am closing this PR as of now, if you fix these, you can reopen it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/Upyogaarth/pull/37#issuecomment-939223900, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZGWFQLBB62JSFF4XUAOJTUF7ADNANCNFSM5FUXET2Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.