Implemented grouping of rows

Manan-Arora31 commented 1 year ago

Description

Earlier all the rows of the homepage appeared in the order of first come first serve basis . But now all the active rows appear as a group above all the inactive rows .

Related Issue

Fixes #4

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Motivation and Context

It is required as it improves readability for the user.

How Has This Been Tested?

I ran the website on my local server and checked that the functionality is working properly.

Screenshots (if appropriate):

Checklist:

[x] I have registered myself at Contrihub website.
[ ] My code follows the code style of this project.
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Manan-Arora31 commented 1 year ago

@the-evocative-eye I am not able to get what changes you are saying . This is the code I have commited . All the columns are visible in this and there are no extra curly braces . Please clarify

Screenshot 2023-10-11 155203 Screenshot 2023-10-11 155214

the-evocative-eye commented 1 year ago

@the-evocative-eye I am not able to get what changes you are saying . This is the code I have commited . All the columns are visible in this and there are no extra curly braces . Please clarify

Ohh Okay, sorry, my bad, one more thing, Id's would then not be arranged sequentially if you keep i+1 in ID and arrange it based on status, and we want IDs to be in order(1,2,3, and so on) even after arranging it based on status. Just try solving this issue too!

Manan-Arora31 commented 1 year ago

Can I still work on this issue ? The time alloted to me is over

On Thu, 12 Oct 2023, 13:34 Taniya Agarwal, @.***> wrote:

@the-evocative-eye https://github.com/the-evocative-eye I am not able to get what changes you are saying . This is the code I have commited . All the columns are visible in this and there are no extra curly braces . Please clarify

[image: Screenshot 2023-10-11 155203] https://user-images.githubusercontent.com/115869448/274232862-3f0474e6-029b-4fbe-afe1-a56d724e8140.png [image: Screenshot 2023-10-11 155214] https://user-images.githubusercontent.com/115869448/274232893-cf92c20f-b9fd-40db-9b8c-0d15d426a12f.png

Ohh Okay, sorry, my bad, one more thing, Id's would then not be arranged sequentially if you keep i+1 in ID and arrange it based on status, and we want IDs to be in order(1,2,3, and so on) even after arranging it based on status. Just try solving this issue too!

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/User-management-system/pull/7#issuecomment-1759131093, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3UAOCGACCN6HLOLPDZ4IADX66QAFANCNFSM6AAAAAA53LTYEM . You are receiving this because you authored the thread.Message ID: @.***>

the-evocative-eye commented 1 year ago

Yes, please go ahead!

On Thu, 12 Oct, 2023, 2:12 pm Manan-Arora31, @.***> wrote:

Can I still work on this issue ? The time alloted to me is over

On Thu, 12 Oct 2023, 13:34 Taniya Agarwal, @.***> wrote:

@the-evocative-eye https://github.com/the-evocative-eye I am not able to get what changes you are saying . This is the code I have commited . All the columns are visible in this and there are no extra curly braces . Please clarify

[image: Screenshot 2023-10-11 155203] < https://user-images.githubusercontent.com/115869448/274232862-3f0474e6-029b-4fbe-afe1-a56d724e8140.png> [image: Screenshot 2023-10-11 155214] < https://user-images.githubusercontent.com/115869448/274232893-cf92c20f-b9fd-40db-9b8c-0d15d426a12f.png>

Ohh Okay, sorry, my bad, one more thing, Id's would then not be arranged sequentially if you keep i+1 in ID and arrange it based on status, and we want IDs to be in order(1,2,3, and so on) even after arranging it based on status. Just try solving this issue too!

— Reply to this email directly, view it on GitHub < https://github.com/ContriHUB/User-management-system/pull/7#issuecomment-1759131093>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/A3UAOCGACCN6HLOLPDZ4IADX66QAFANCNFSM6AAAAAA53LTYEM>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/ContriHUB/User-management-system/pull/7#issuecomment-1759185706, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXHEHI3SRW5UPQXLWK26VS3X66UN7ANCNFSM6AAAAAA53LTYEM . You are receiving this because you were mentioned.Message ID: @.***>

Manan-Arora31 commented 1 year ago

@the-evocative-eye I have made the required changes. Please check.

ContriHUB / User-management-system