search

ContriHUB / WithYou

A personal safety android app
3 stars 22 forks source link

added photo sharing feature: issue #13 #50

Closed mitrukahitesh closed 3 years ago

mitrukahitesh commented 3 years ago

Fixed #13

rjankit commented 3 years ago

Can you elaborate how your feature is working?

mitrukahitesh commented 3 years ago

Yes, sure. Whenever a user clicks a picture, a file is generated. This particular file is uploaded to ImgBB by making a POST request to its API corresponding to which a URL is provided. This URL is stored and sent with the location message. For making API call, I have used Retrofit.

mitrukahitesh commented 3 years ago

The repository owner needs to sign in with ImgBB to get an API key. For now, I have used my credential. It is stored in MainActivity.

rjankit commented 3 years ago

It would be better if the app clicks the image directly, when Panic button is pressed, show a progress bar while the image is being uploaded, and then sends the location and URL automatically. Can you do that?

mitrukahitesh commented 3 years ago

Is there an emergency button in the app or do I have to add a button? I could not find the emergency button.

rjankit commented 3 years ago

I meant to say the panic button.

On Fri, 22 Oct 2021, 18:55 Hitesh Mitruka, @.***> wrote:

Is there an emergency button in the app or do I have to add a button? I could not find the emergency button.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/WithYou/pull/50#issuecomment-949629892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK6J6HQYA5UVY55VCEY2Q4TUIFQ3TANCNFSM5GPY24RQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mitrukahitesh commented 3 years ago

My bad. The question is: Is there a panic button in the app or do I have to add a button? I could not find the panic button.

rjankit commented 3 years ago

There is a panic button, when pressed, send the location to the number being set.

On Fri, 22 Oct 2021, 18:58 Hitesh Mitruka, @.***> wrote:

My bad. The question is: Is there a panic button in the app or do I have to add a button? I could not find the panic button.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ContriHUB/WithYou/pull/50#issuecomment-949632427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK6J6HRBOPMME4ORYC7ZNW3UIFRHVANCNFSM5GPY24RQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mitrukahitesh commented 3 years ago

Okay. I will do that. Please allow me some time.

mitrukahitesh commented 3 years ago

@rjankit, I have implemented the desired behaviour.

rjankit commented 3 years ago

There are compilation errors in your commit. Do check once.

mitrukahitesh commented 3 years ago

Please review now. I deleted my piece of code while fixing the merge conflict by mistake.

rjankit commented 3 years ago

LGTM!