Contributees / First-Ruby-Quest

Web app referencing ruby related open source issues suitable for a first contribution and/or junior developers (or any developpers!)
MIT License
1 stars 2 forks source link

Fix li elements #37

Closed Oli0li closed 8 months ago

Oli0li commented 8 months ago

What does this PR do?

The default list style for Tailwind is list-style-type: none. This is why we couldn't see bullet points or numbers when using li elements in unordered or ordered lists. So I have reverted this as per the answer of this StackOverflow question: https://stackoverflow.com/questions/69276276/why-tailwind-list-style-type-is-not-working

I just realised I had also committed app/assets/stylesheets/application.scss. The change was made automatically by my linter, it is not linked to lists in any way in case you're wondering.

Screenshot

Screenshot 2024-02-12 161009

Related issue

https://github.com/Contributees/First-Ruby-Quest/issues/14

References

This is the base style for Preflight: https://tailwindcss.com/docs/preflight#lists-are-unstyled

And these are the possible classes for list style types in Tailwind: https://tailwindcss.com/docs/list-style-type