search

Contributees / First-Ruby-Quest

Web app referencing ruby related open source issues suitable for a first contribution and/or junior developers (or any developpers!)
MIT License
1 stars 2 forks source link

Make changes on the hero #40

Open Oli0li opened 7 months ago

Oli0li commented 7 months ago

I think some changes might be needed on the hero:

image

  1. The sign up button is slightly smaller than the "Get help on an issue" button next to it. But actually, I think we could remove it altogether since there's already a "Sign up" button not far from it on the navbar.

  2. GitHub logo: I am not sure we are allowed to use it in such a prominent way and with a gray background (see https://github.com/logos). If we remove it, we should probably change "beginner-friendly issues" to "beginner-friendly GitHub issues" so that it's clearer what this is about.

awalsh3 commented 7 months ago

Hey!

Thanks for this. I agree on both points!

Should we replace the GitHub logo with some kind of illustration like you designed for one of the other pages?

-Or -

Would it look odd if the logo is white and the background is still grey if we keep it there?

awalsh3 commented 7 months ago

To Do:

Oli0li commented 7 months ago

Hey!

Thanks for this. I agree on both points!

Should we replace the GitHub logo with some kind of illustration like you designed for one of the other pages?

-Or -

Would it look odd if the logo is white and the background is still grey if we keep it there?

Thank you @awalsh3 for looking into this, I think it might be best to replace it, though I'm not sure with what. Feel free to try something new, whether it's with an illustration or something different for the background, I don't really have a particular idea but I'm very much open to suggestions! 😄

awalsh3 commented 7 months ago
Screenshot 2024-02-28 at 13 09 43

I made this in canva - an open-source icon with a ruby gem! Let me know what you think.

Oli0li commented 7 months ago

Sorry for the delayed reply @awalsh3 and thank you so much for looking into this! I didn't know this was the icon for "open source" at first so I admit that the meaning was not clear to me immediately, but now that I know it makes sense. So I'm fine with that, or alternatively just any type of ruby-themed icon.

@ClaireDMT @leawhitelaw @Huiclaire @Samgalgo, what do you think?

awalsh3 commented 7 months ago

Ah right yeah, newer devs will probably think the same. Maybe something else would be better. What about something related to the logo... "Quest" like? The logo needs a change as well? Maybe this can be combined into one issue for a brand design?

awalsh3 commented 7 months ago
Screenshot 2024-03-12 at 16 44 24

Until we get a logo design maybe a placeholder for now could be this?