ContributorCovenant / beacon

A code of conduct reporting and management system created by Coraline Ada Ehmke, the author of the Contributor Covenant.
Apache License 2.0
32 stars 10 forks source link

[BUG] Can't edit CoC consequences #239

Closed DEGoodmanWilson closed 5 years ago

DEGoodmanWilson commented 5 years ago

All contributions, including pull requests, issues, and comments, are governed by our code of conduct.

Description of the bug

From page https://www.coc-beacon.com/organizations/{$ORG_NAME}/consequence_guide, I cannot edit existing consequences. Clicking the "edit" button makes the editable field appear, as expected, but then they dissappear, as in the attached screenshot

Reproducting the bug

Steps to reproduce the behavior:

  1. Go to https://www.coc-beacon.com/organizations/{$ORG_NAME}/consequence_guide
  2. Click on 'clone', using the Beacon Defaults
  3. Scroll down to 'Level 1: Correction'
  4. Click on 'edit', see error

Expected behavior

I had hoped to have editable fields, so I coud change the consequnces.

Screenshots

Here's a screencap. Apologies that it is a little glitchy. But you can see me scroll down, hit 'edit', and the editable fields appear, then dissappear. I attempt it three times before ending the recording (which loops).

beaconconsequencesedit

Desktop environment

Additional context

There don't seem to by any errors in the JS console as a result of clicking 'edit', but these errors do exist when I visit the page: None of the "sha384" hashes in the integrity attribute match the content of the subresource.

The resource at “https://www.google-analytics.com/analytics.js” was blocked because content blocking is enabled.

CoralineAda commented 5 years ago

I couldn't reproduce this (Firefox 67.0.1) but I suspect that since I was using a button control the page was reloading. I changed this to a link to see if that addresses the problem.

CoralineAda commented 5 years ago

(The PR is in CI, will be deployed in about 10 minutes)

CoralineAda commented 5 years ago

The proposed fix is pushed up, @DEGoodmanWilson will you try again when you have the chance?

DEGoodmanWilson commented 5 years ago

Looks good! Form behaves as expected now. Thank you! (Unsure who is responsible for closing issues here…)