Share link not working - Githubissues

ControlCore-Project / concore-editor

The concore Editor

http://controlcore-project.github.io/concore-editor

BSD 3-Clause "New" or "Revised" License

9 stars 19 forks source link

Share link not working #100

Closed parteekcoder closed 1 year ago

parteekcoder commented 1 year ago

Reproduce

create a graphml file
click share and copy the url
Go to that url

You will not find anything there

@pradebaan assign it to me, Will make PR for this shorty around next week

pradeeban commented 1 year ago

I get the "Error: URI Too Long" when I go to that URL.

Is it the same error you are getting?

pradeeban commented 1 year ago

I wonder whether we should just remove the "Share" option from there. I don't remember using that feature ever. https://github.com/ControlCore-Project/concore-editor/issues/97#issuecomment-1444071973

parteekcoder commented 1 year ago

I get the "Error: URI Too Long" when I go to that URL.

Is it the same error you are getting?

No, i got an empty editor, there wasn't any error in my case

which browser you are using

pradeeban commented 1 year ago

For both Chrome and Firefox (on MacOS), I get "Error: URI Too Long" in an otherwise empty browser tab.

parteekcoder commented 1 year ago

I wonder whether we should just remove the "Share" option from there. I don't remember using that feature ever. #97 (comment)

yeah, we can disable or remove that option for now @pradeeban what you say shall I remove it from the page for now

pradeeban commented 1 year ago

@parteekcoder Sure, please create a PR, if it is a trivial fix with very few changes to just one file. If it needs edits to many files, we can ignore the bug for now (while keeping the bug report open).

parteekcoder commented 1 year ago

@pradeeban yeah pradeeban actually changes can be of one line but I have to analyze the whole code related to share ,

So now will remove share button from the scrren by commenting code

Or leave it for now

But I will ensure you in 1 or 2 days I will solve it

pradeeban commented 1 year ago

@parteekcoder There is no rush. You can take your time.

The bug is not critical. It is an unused, broken feature. Either we fix the feature (if it is trivial) or remove the option from the front end (if that is trivial). We can leave this bug report open if both take a significant effort.

This is my recommended approach for all the uncritical bugs of the concore editor.

pradeeban commented 1 year ago

I wonder whether we should just remove the "Share" option from there. I don't remember using that feature ever. #97 (comment)

With your latest findings on #107, I would say let's just remove the "Share" button from the front end from now.

You can keep the functionality hanging around so that this can be fixed later if needed later.

But for now, just removing the button from the display should be sufficient. That should be a one-line change if I understood the code correctly.

pradeeban commented 1 year ago

Closed with the merge of #110. The "Share" option is a Won't Fix now.