search

ControlCore-Project / concore-editor

The concore Editor
http://controlcore-project.github.io/concore-editor
BSD 3-Clause "New" or "Revised" License
9 stars 19 forks source link

issue #101 fixed (again solved) #103

Closed Rahuljagwani closed 1 year ago

Rahuljagwani commented 1 year ago

@pradeeban Sorry for previous PR. I have fixed the changes you mentioned in PR #102. It can be tested here: https://rahuljagwani.github.io/concore-editor/

But there is one more issue that whether or not the graph displayed is created by user or uploaded, when browser reload happens then again the error "Switch to edge/Chrome" appears when clicked on Save Button. I will create a separate issue for this and try to send a PR. (Its an existing issue even now)

pradeeban commented 1 year ago

This is neat. I had conflicting opinions on the Alert you introduced. alert('File saved Successfully');

But I am more with you that previously without this alert, we were not sure whether the "Save" worked or not, especially with #58 appearing at times.

So I will merge this commit as is.

Rahuljagwani commented 1 year ago

This is neat. I had conflicting opinions on the Alert you introduced. alert('File saved Successfully');

But I am more with you that previously without this alert, we were not sure whether the "Save" worked or not, especially with #58 appearing at times.

So I will merge this commit as is.

Can u please elaborate about the conflictions with alert('File saved Successfully') ??

pradeeban commented 1 year ago

Can u please elaborate about the conflictions with alert('File saved Successfully') ??

Oh, this is a new Alert you have introduced. I usually dislike chatty messages that expect you to click "OK" or respond to continue working. But such notification is nice on this occasion as previously we had no clue whether the "Save" was properly executed or not (prompting us to click "Save" twice or thrice, "just in case.") The animation for the Save button (or any buttons) to show they were clicked is weak in concore editor.

Rahuljagwani commented 1 year ago

Can u please elaborate about the conflictions with alert('File saved Successfully') ??

Oh, this is a new Alert you have introduced. I usually dislike chatty messages that expect you to click "OK" or respond to continue working. But such notification is nice on this occasion as previously we had no clue whether the "Save" was properly executed or not (prompting us to click "Save" twice or thrice, "just in case.") The animation for the Save button (or any buttons) to show they were clicked is weak in concore editor.

Yes, it can be irritating to give responses in form of clicks for users. In future we can use a [spinner + check mark] ( just like what github shows while performing checks on PRs ) or a notification to show file saved successfully. In that case user will not have to click buttons to respond.

pradeeban commented 1 year ago

Yes, those are good suggestions.

parteekcoder commented 1 year ago

@pradeeban is this change is in production

Rahuljagwani commented 1 year ago

@pradeeban is this change is in production

Not yet, You can check in actions

pradeeban commented 1 year ago

To reflect the changes to the production, I must follow these steps as listed in the README:

"Please go to the url https://github.com/ControlCore-Project/concore-editor/actions/workflows/buildAndDeploy.yml and trigger this particular workflow."

I do it occasionally. You should be able to check when I invoked the "Actions," by going to the "Actions" tab. I can do it in a couple of minutes since you both are discussing that.