search

ControlCore-Project / concore-editor

The concore Editor
http://controlcore-project.github.io/concore-editor
BSD 3-Clause "New" or "Revised" License
9 stars 19 forks source link

removing alert statements #121

Closed parteekcoder closed 1 year ago

parteekcoder commented 1 year ago

@pradeeban

As alert statements degrades user experience , I am removing them

pradeeban commented 1 year ago

That removed the alert, but did not introduce the flash in Firefox. So, I have closed the PR. Please open a new one that is tested on Firefox also.

parteekcoder commented 1 year ago

Yeah , I sorry for the inconvenience caused to you , i will update that PR

pradeeban commented 1 year ago

No worries, and no rush. Feel free to take your time.

pradeeban commented 1 year ago

merged to main.