search

ControlCore-Project / concore-editor

The concore Editor
http://controlcore-project.github.io/concore-editor
BSD 3-Clause "New" or "Revised" License
9 stars 19 forks source link

Login or sign up #145

Open parteekcoder opened 1 year ago

parteekcoder commented 1 year ago

Hey @pradeeban ,

In GSoC project 10, we allow users to upload their examples to github repository of concore, as we are thinking of the solution that not require user to have a github account but to keep track of users we should track their google account or something like that

Hence we should authenticate users with their google account or similar like that instead of github account which all users don't have

And we can also use that google account to differentiate and keep track of their PR from other users So I would like to work upon this

pradeeban commented 1 year ago

Hi @parteekcoder, Good points.

You are thinking of a Single Sign-On with Google, I believe. As of now, we can keep track of the users in the contribute options (in theory, since the implementation is not complete yet) through the author name (which is a random string, actually), since you fixed that author name bug.

But having a Google sign-on could also help with the security aspect, as in OpenID, instead of the current API Key-based approach on FRI (which also is not complete yet).

Valid points to consider. We need to think a bit more about how this design will go and any caveats or road blocks. (What if one does not have a Google account. Not everyone has a Google account either).

parteekcoder commented 1 year ago

Hi @parteekcoder, Good points.

You are thinking of a Single Sign-On with Google, I believe. As of now, we can keep track of the users in the contribute options (in theory, since the implementation is not complete yet) through the author name (which is a random string, actually), since you fixed that author name bug.

But having a Google sign-on could also help with the security aspect, as in OpenID, instead of the current API Key-based approach on FRI (which also is not complete yet).

Valid points to consider. We need to think a bit more about how this design will go and any caveats or road blocks. (What if one does not have a Google account. Not everyone has a Google account either).

yeah I will shortly send you my approch to handle this

pradeeban commented 1 year ago

Sounds good. We can discuss the approach further (either here or in your proposal draft).