search

ControlCore-Project / concore-editor

The concore Editor
http://controlcore-project.github.io/concore-editor
BSD 3-Clause "New" or "Revised" License
9 stars 19 forks source link

Convert to js function #148

Open parteekcoder opened 1 year ago

parteekcoder commented 1 year ago

Hi @pradeeban ,

The functions here are written in string format https://github.com/ControlCore-Project/concore-editor/blob/main/src/config/defaultValidators.js

Is there any specific reason for this

pradeeban commented 1 year ago

What is the alternative approach you would suggest?

(Please note these are our previous GSoC students' work from 2022 and 2021. The Concore editor as a whole is a product of GSoC 2021 and 2022.)

parteekcoder commented 1 year ago

I will make this as JS function and use export/import syntax which will be much better

Why to refactor? Ans: Now if any person wants to call a function inside that function which is written in string that is not possible . Because it can't find that reference of function called inside that

pradeeban commented 1 year ago

ok, great.