willrogers
commented
5 years ago See #2530.
I am working with Ito and I can build this, but I don't know why he can't. Does anyone understand the error? Does it just mean that JavaFX is not there?
Closed ghost closed 5 years ago
willrogers
commented
5 years ago See #2530.
I am working with Ito and I can build this, but I don't know why he can't. Does anyone understand the error? Does it just mean that JavaFX is not there?
willrogers
commented
5 years ago I just noticed that Ito doesn't seem to be using openjdk. We will try that.
ghost
commented
5 years ago Still the exact same error, even with open jdk11
(issue_2530_EB) [tph19377@ws012 applications]$ java --version
openjdk 11.0.2 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)@berryma4 @shroffk any ideas?
berryma4
commented
5 years ago Let me try to reproduce the error, Kunal recently was able to build though.
On Mon, Apr 8, 2019, 07:59 Will Rogers notifications@github.com wrote:
@berryma4 https://github.com/berryma4 @shroffk https://github.com/shroffk any ideas?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ControlSystemStudio/cs-studio/issues/2570#issuecomment-480801978, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0IBbcrMTpEQ2PJ1575z6wcLS1HW-EKks5vey8cgaJpZM4ch10e .
willrogers
commented
5 years ago I can build it without errors, that's the strange thing.
kasemir
commented
5 years ago With Java 11, the JDK no longer includes JavaFX. It needs to be fetched from org.openjfx. The error
[ERROR] /scratch/tph19377/tmp/cs-studio/applications/logbook/logbook-plugins/org.csstudio.logbook.olog.property.fault/src/jfxtras/controls/agenda/AgendaLastWeekDaysFromDisplayedSkin.java:[236]
[ERROR] public static List<CssMetaData<? extends Styleable, ?>> getClassCssMetaData() {
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The return type is incompatible with AgendaSkinTimeScale24HourAbstract<AgendaLastWeekDaysFromDisplayedSkin>.getClassCssMetaData()
[ERROR] /scratch/tph19377/tmp/cs-studio/applications/logbook/logbook-plugins/org.csstudio.logbook.olog.property.fault/src/jfxtras/controls/agenda/AgendaLastWeekDaysFromDisplayedSkin.java:[247]
[ERROR] public List<CssMetaData<? extends Styleable, ?>> getCssMetaData() {
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The return type is incompatible with AgendaSkinTimeScale24HourAbstract<AgendaLastWeekDaysFromDisplayedSkin>.getCssMetaData()
[ERROR] 2 problems (2 errors)
[ERROR] -> [Help 1]could mean you somehow get two different JavaFX versions into the build. One might be the OpenJavaFX 11 that you want to use, and the other some older version that the jfxtras dependency drags in.
shroffk
commented
5 years ago I will double check the jfxtras dependency tree... Last week I was able to build the entire cs-studio product from the Issue_2030_EB branch without issue.
ghost
commented
5 years ago With Java 11, the JDK no longer includes JavaFX. It needs to be fetched from org.openjfx. The error
[ERROR] /scratch/tph19377/tmp/cs-studio/applications/logbook/logbook-plugins/org.csstudio.logbook.olog.property.fault/src/jfxtras/controls/agenda/AgendaLastWeekDaysFromDisplayedSkin.java:[236] [ERROR] public static List<CssMetaData<? extends Styleable, ?>> getClassCssMetaData() { [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [ERROR] The return type is incompatible with AgendaSkinTimeScale24HourAbstract<AgendaLastWeekDaysFromDisplayedSkin>.getClassCssMetaData() [ERROR] /scratch/tph19377/tmp/cs-studio/applications/logbook/logbook-plugins/org.csstudio.logbook.olog.property.fault/src/jfxtras/controls/agenda/AgendaLastWeekDaysFromDisplayedSkin.java:[247] [ERROR] public List<CssMetaData<? extends Styleable, ?>> getCssMetaData() { [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [ERROR] The return type is incompatible with AgendaSkinTimeScale24HourAbstract<AgendaLastWeekDaysFromDisplayedSkin>.getCssMetaData() [ERROR] 2 problems (2 errors) [ERROR] -> [Help 1]could mean you somehow get two different JavaFX versions into the build. One might be the OpenJavaFX 11 that you want to use, and the other some older version that the jfxtras dependency drags in.
Sorry, this was the problem; there was a line in my .mavenrc file which was setting JAVA_HOME to a jlink environment, closing the issue, thanks for the help.
Building cs-studio with the issue_2530_EB branch (Java 11) generates these jfxtras errors:
I have a local composite p2 repo which points to maven-osgi-bundles and cs-studio-thirdparty, both of which have also checked out the branch issue_2530_EB, as well the p2 repo at the main cs-studio repo.
The output of my
java --versionis:And I have my JAVA_HOME variable pointing to my local 11.0.2 folder. Can anyone help with this?