search

ControlSystemStudio / cs-studio

Control System Studio is an Eclipse-based collections of tools to monitor and operate large scale control systems, such as the ones in the accelerator community.
https://controlsystemstudio.org/
Eclipse Public License 1.0
113 stars 96 forks source link

#2437 adding action in BOY to open resources in phoebus #2590

Closed shroffk closed 5 years ago

shroffk commented 5 years ago

There is a configurable extra action which would allow users to launch resources using phoebus applications

shroffk commented 5 years ago

image

shroffk commented 5 years ago

@berryma4 how are we to manage PR's

berryma4 commented 5 years ago

Yes, the Travis build goes over the time limit. I just run the build.

I'm fine with the PR if Will is too.

shroffk commented 5 years ago

@willrogers Eric is waiting for your input

willrogers commented 5 years ago

I made a couple of comments, but it generally looks fine.

berryma4 commented 5 years ago

@shroffk could you change the default property to use_phoebus=false

shroffk commented 5 years ago

Done, I have included the above recommendations

berryma4 commented 5 years ago

@shroffk default use_phoebus is still true, could you change it to false

berryma4 commented 5 years ago

I think you change the wrong line: https://github.com/ControlSystemStudio/cs-studio/commit/e08eb5ad5bfaaea3fdba2e487671ebbdab7e75e6#diff-bc49ee5bf2f29615acd90e58617543ccL122