search

ControlSystemStudio / cs-studio

Control System Studio is an Eclipse-based collections of tools to monitor and operate large scale control systems, such as the ones in the accelerator community.
https://controlsystemstudio.org/
Eclipse Public License 1.0
111 stars 96 forks source link

Update .travis.yml #2643

Closed shroffk closed 3 years ago

willrogers commented 4 years ago

Aha @shroffk I think you have the same problem I described in #2640. Do you think it is the same thing?

My manager would now like me to try to resolve this build problem. I would rather eat slugs but there we are.

shroffk commented 4 years ago

well... I guess with the right seasoning slugs could be palatable. Can't say the same about batik problems.

willrogers commented 4 years ago

I have a 'fix' for the Batik problem that allows the build to succeed. Whether it works correctly at runtime is not certain.

This should now be failing on genuine test failures introduced in #2642.

shroffk commented 4 years ago

Ok, Should this be merged?

shroffk commented 4 years ago

I was able to recreate the test failures and will look into them tomorrow

willrogers commented 4 years ago

I did indeed get a runtime problem. The latest changes do appear to work on the one example of SVGs that I can find, although these widgets are a bit fiddly.

I also fixed the tests.

shroffk commented 4 years ago

@willrogers thanks for fixing this

I know that ITER uses SVGs a lot, can someone from @css-iter test this?

shroffk commented 3 years ago

@willrogers can you add your review please