search

ControlSystemStudio / cs-studio

Control System Studio is an Eclipse-based collections of tools to monitor and operate large scale control systems, such as the ones in the accelerator community.
https://controlsystemstudio.org/
Eclipse Public License 1.0
111 stars 96 forks source link

Css442 opi contextmenu focus #2676

Closed willrogers closed 3 years ago

willrogers commented 3 years ago

After opening the context menu with right click and either selecting an item or cancelling, sometimes focus isn't returned to the OPI. This means that the next click on the OPI is not registered as expected.

This PR fixes that problem.

cc @rjwills28

willrogers commented 3 years ago

I'm not entirely sure. Becky said that the fix in the first commit worked if there was a databrowser widget (an SWT widget?) on the page but I found that it didn't always work. The second commit appears to fix the problem always.

rjwills28 commented 3 years ago

I'm not 100% sure but I feel like it might be an SWT issue from the research I was doing to find a fix. It certainly isn't an issue in Phoebus.