search

ControlSystemStudio / cs-studio

Control System Studio is an Eclipse-based collections of tools to monitor and operate large scale control systems, such as the ones in the accelerator community.
https://controlsystemstudio.org/
Eclipse Public License 1.0
111 stars 96 forks source link

Css551 trace annotation visibility #2683

Closed willrogers closed 3 years ago

willrogers commented 3 years ago

@kasemir this is not a trivial fix, so please have a look at the implementation.

rjwills28 commented 3 years ago

Something strange happened when I did a rebase with the style-checks in the newer master branch. Scrapping this PR and branch. I will create a new branch with just the correct commits and create a new PR.

kasemir commented 3 years ago

If you're redoing it, you could also compare with the Phoebus version. Your original approach was to add/remove traces and annotations from the plot as they are visible/hidden. In phoebus, I now always add all traces and annotations to the plot, and simply update their 'visible' property. That way, the 'index' of a trace in the plot always matches the 'index' in the model, overall simpler.

kasemir commented 3 years ago

I think this one is obsolete, handled by #2685