search

ControlSystemStudio / cs-studio

Control System Studio is an Eclipse-based collections of tools to monitor and operate large scale control systems, such as the ones in the accelerator community.
https://controlsystemstudio.org/
Eclipse Public License 1.0
113 stars 96 forks source link

Trace annotation visibility (build fix) #2685

Closed rjwills28 closed 3 years ago

rjwills28 commented 3 years ago

This is the same fix described in PR https://github.com/ControlSystemStudio/cs-studio/pull/2683. There was an issue with the rebase required to bring the branch up to date with the latest code style fixes as so I created a new branch and hence new PR.

rjwills28 commented 3 years ago

@kasemir I took a look at the Phoebus implementation and found a few edge cases where the annotations can get lost after hiding and showing a trace. If you hide an existing trace (with annotations), then add a brand new trace and then show the previously hidden one, it re-appears with out its annotation. Also I noticed that the Edit Annotation window shows all of the annotations including those for the traces that are hidden.

I think both of these issues should be fixed in this PR for CS-Studio.

kasemir commented 3 years ago

Thanks for checking that! I agree on the issue where annotation is lost when adding new trace, will have to fix that in the phoebus version. As for the annotation editor, I think it's a feature to allow editing all annotations, including those for hidden traces, and those which are currently positioned off screen. If nothing else, it allows you to delete them.