search

ControlSystemStudio / cs-studio

Control System Studio is an Eclipse-based collections of tools to monitor and operate large scale control systems, such as the ones in the accelerator community.
https://controlsystemstudio.org/
Eclipse Public License 1.0
113 stars 96 forks source link

Resize the legend area when traces are hidden #2725

Closed rjwills28 closed 6 months ago

rjwills28 commented 7 months ago

We came across an issue in the databrowser where the area taken up to display the traces legend does not shrink when traces are hidden. This is particular noticeable if the plot contains many traces of which most are hidden. It turns out that in the code the legend area is determined using all the traces even if they are not being displayed. This PR fixes this issue by only considering the visible traces.

rjwills28 commented 7 months ago

Build fails due to an unrelated issue - see fix in PR https://github.com/ControlSystemStudio/cs-studio/pull/2726. PR 2726 needs to be merged and pulled into this branch first before re-running the CI job for this PR.

kasemir commented 7 months ago

Turns out the JFX version had the 'continue' part but still counted all traces, so thanks for this update

shroffk commented 6 months ago

@rjwills28 can you update this branch... with #2726 merged we should be able to get the CI working again here