search

ControlSystemStudio / cs-studio

Control System Studio is an Eclipse-based collections of tools to monitor and operate large scale control systems, such as the ones in the accelerator community.
https://controlsystemstudio.org/
Eclipse Public License 1.0
111 stars 96 forks source link

Specify minor version of Java to use in GitHub action #2726

Closed rjwills28 closed 3 months ago

rjwills28 commented 4 months ago

There is a problem with the CSS build using the latest version of Java11 (11.0.21). This is what is used by the GitHub CI by default if you only specifying the major version of Java to use as we currently do (i.e. 11). The error is due to a signing issue in the jython-standalone package we download:

Error:  Failed to execute goal org.reficio:p2-maven-plugin:1.3.0:site (default-cli) on project maven-osgi-repository: 
Execution default-cli of goal org.reficio:p2-maven-plugin:1.3.0:site failed: java.lang.RuntimeException: Error while bundling jar or 
source: jython-standalone-2.7.1.jar: The JAR/ZIP file (/home/runner/.m2/repository/org/python/jython-standalone/2.7.1/jython-
standalone-2.7.1.jar.d0685bba-07f7-4512-bcd6-f690f85bd948) seems corrupted, error: Invalid CEN header (invalid extra data field
 size for tag: 0xbfef at 130358) -> [Help 1]

This check is something that has been introduced from Java 11.0.20 as an extra security check. Without the jython-standalone signature being fixed the only solution for us is to specify the use of Java 11.0.19 in the GitHub CI build.

rjwills28 commented 4 months ago

Is anyone available to review this PR as the fix is needed before https://github.com/ControlSystemStudio/cs-studio/pull/2725 can be reviewed?