search

ControlSystemStudio / phoebus

A framework and set of tools to monitor and operate large scale control systems, such as the ones in the accelerator community.
http://phoebus.org/
Eclipse Public License 1.0
85 stars 86 forks source link

Filebrowser: Indicate symbolic links? #2443

Open kasemir opened 1 year ago

kasemir commented 1 year ago

The file browser currently doesn't know/indicate if a file or folder is a symbolic link. In principle, we could check via Files.isSymbolicLink https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#isSymbolicLink(java.nio.file.Path) and then indicated that via for example an overlay on the file icon, or in the "Properties" info accessible via the context menu.

Should we do that, because it provides a little more information?

Or should we actually NOT do that?

kasemir commented 1 year ago

My vote: No, because that level of directory layout detail is of no concern to the CS-Studio end user. System maintainers may configure the file browser start location to some folder that contains either "real" content or symbolic links, and symbolic links are used precisely to present some layout to the end user that is meant to be indistinguishable from a "real" layout. Those who need to know more can use system tools.

georgweiss commented 1 year ago

As the technical side of it seems straight forward, I'd vote yes. But I'd not like to make the Filebrowser a replacement for the native tools. I can think of other types of enhancements that would make sense to the CS Studio context, e.g. a filtering mechanism.