search

ConvLab / ConvLab-3

Apache License 2.0
104 stars 30 forks source link

TripPy DST #135

Open AtheerAlgherairy opened 1 year ago

AtheerAlgherairy commented 1 year ago

I trained TripPy on a dataset in the unified format. I have the path to a model checkpoint. When I use it, I got the following error:

Screen Shot 1444-07-21 at 11 55 08 AM

Screen Shot 1444-07-21 at 11 51 21 AM

Then, I changed the followings in trippy/tracker.py

_ontology = relative_import_module_from_unified_datasets(self.dataset_name, 'preprocess.py', 'ontology')

to

_ontology = load_ontology(self.dataset_name)

I got the following error:

Screen Shot 1444-07-21 at 12 07 20 PM

zqwerty commented 1 year ago

_ontology = relative_import_module_from_unified_datasets(self.dataset_name, 'preprocess.py', 'ontology')

the loaded ontology is from multiwoz21/preprocess.py: https://github.com/ConvLab/ConvLab-3/blob/84251cfddd28e69385551ee40c583c3460633d81/data/unified_datasets/multiwoz21/preprocess.py#L12

which is not a good way to use unified ontology.

@carelvniekerk could you use load_ontology instead and fix the bug?

carelvniekerk commented 1 year ago

Hey, I will look into this.