search

ConvertAPI / convertapi-library-dotnet

A .NET library for the ConvertAPI
https://www.convertapi.com
Other
22 stars 8 forks source link

Do not pass any TimeOut to ConvertAPI and set HTTP Client timeout to 1800 seconds #24

Closed tomasr78 closed 2 years ago

tomasr78 commented 4 years ago

Do not pass any TimeOut to ConvertAPI and set HTTP Client timeout to 1800 seconds. The idea is to use the default timeout of ConvertAPI if no timeout is set and to prevent HTTP Client request deadlock set default HTTPClient timeout to 1800 seconds.

If, however, timeout is set we handle it as before, pass a timeout to ConvertAPI and set HTTPClient Timeout to: ConvertAPITimeOut+conversion_timeout_delta

conversion_timeout_delta = 10

tomasr78 commented 3 years ago

Also, move Timeout to properties as all ConvertAPI properties, makes no sense to use methods or configs to set timeouts that fully depend on Rest API timeout. This is very confusing when setting properties used one method but for Timeout - totally different scenario.

tomasr78 commented 3 years ago

After this update need to update code snippets https://github.com/Baltsoft/CA-Web/issues/388

tomasr78 commented 2 years ago

a