search

ConvertAPI / convertapi-library-go

A Go library for the ConvertAPI
https://www.convertapi.com
Other
14 stars 8 forks source link

The main convert method do not use ConvertAPI naming convention #6

Closed tomasr78 closed 4 years ago

tomasr78 commented 4 years ago

The main convert method do not use ConvertAPI naming convention, instead of convertapi.ConvDef should be convertapi.Convert, the same applies to snippets.

https://github.com/ConvertAPI/convertapi-go/blob/a822cefe0641ce45c4acd7a59c8b4f1266aeb196/convert.go#L12

JonasJasas commented 4 years ago

By design. As GO has no default values for parameters nor function overloads so this function takes less arguments and replaces with the defalt values.

tomasr78 commented 4 years ago

When maybe we could swap names? The full method could be ConvDef and smaller alternate version Convert? Which version would be used more often?

JonasJasas commented 4 years ago

Fixing issue that don't exist would introduce breaking changes.