search

ConvertKit / slate-plugins

A collection of plugins for SlateJS, maintained by ConvertKit
https://convertkit-slate-plugins.netlify.com/
MIT License
52 stars 22 forks source link

Migrate renderNode to renderBlock #38

Closed pkeuter closed 5 years ago

pkeuter commented 5 years ago

To be compatible with version 0.22 of slate-react (https://github.com/ianstormtaylor/slate/blob/master/packages/slate-react/Changelog.md#0220--may-8-2019)

Since this library uses only block-types, it's an easy naming-change.

brendancarney commented 5 years ago

Thanks for the PR @pkeuter! What do you think about adding this in right below L111:

renderNode: renderBlock, // COMPAT: renderNode is removed in slate

That way, this would be backward compatible for now.

pkeuter commented 5 years ago

Hey @brendancarney, thanks for the quick response. And thanks for the library! It's very useful. Good point about the compatibility with older versions, I've just added it.

brendancarney commented 5 years ago

Released in 0.2.3