search

Convex-Dev / convex

Convex Main Repository - Decentralised platform for the Internet of Value
https://convex.world
Other
95 stars 30 forks source link

`convex.asset/get-offer` does not support paths #475

Closed helins closed 11 months ago

helins commented 1 year ago

Presumably, the first argument should a path. The current implementation only supports an address.

(fn [asset-address sender receiver] (query (#16/call* %0 0 get-offer %1 %2)))
mikera commented 1 year ago

Looks sane. Just interaction with *scope* may need some consideration across the board. I think scoped assets instead of raw addresses are likely to be preferable in most circumstances

helins commented 1 year ago

I'm referring to the current pattern of using paths which doesn't require *scope*. Similarly, check-transfer currently supports only raw addresses.