search

ConveyChat / Convey

A communications platform on layer 1 Ethereum - Built at ETHWaterloo 2
https://devpost.com/software/connexion-vy3a9c
7 stars 3 forks source link

Smart Contract Events #8

Open jsdu opened 4 years ago

jsdu commented 4 years ago

Please discuss which events are needed

haardikk21 commented 4 years ago

I think the current one we have for p2p messages is fine. We do need to include one for broadcast messages, and for future functionality I think we should also add events for when someone starts following someone else, or stops following them.

So basically, 1) broadcast messages 2) subscribe to address 3) unsubscribe to address

For broadcast messages we can use the scheme discussed on call earlier.

mm:<message ipfs hash>:<receiver array ipfs hash>

The others we need to define.

jsdu commented 4 years ago

Why are we specifying an array of receiver array? I feel like that won't scale. It may be better to consider that all broadcasts will be public messages and don't need encryption.

haardikk21 commented 4 years ago

Why are we specifying an array of receiver array? I feel like that won't scale. It may be better to consider that all broadcasts will be public messages and don't need encryption.

Can there not be private broadcasts though? Imagine I am a signals trader and provide paid signals to my community. I would not want the broadcasts to be public.

We don't pass the array directly in the event logs. We upload it to IPFS and only include the hash of the object in the event.

jsdu commented 4 years ago

Are you saying only those who are subscribed to that address will receive them? If so then why is an array of receivers necessary. I thought we are notifying them. If you put the receivers in ipfs how will anyone see that and be notified?

haardikk21 commented 4 years ago

Are you saying only those who are subscribed to that address will receive them?

Yes

If so then why is an array of receivers necessary.

There is another way as drafted in convey-spec

I thought we are notifying them.

That's where the wallet integration with the standard comes in.

If you put the receivers in ipfs how will anyone see that and be notified?

Upon thinking about it more, you're right that's an inefficient way. So the draft in convey-spec takes a different approach at this.