search

ConvoyPanel / panel

A modern platform tailored for hosting providers and enthusiasts to effortlessly interact with their servers. Seamlessly wrapping around Proxmox, Convoy is easily deployable, affordable at just $6 per node per month for commercial use, and completely free for personal and non-profit endeavors.
https://convoypanel.com
Other
308 stars 51 forks source link

Error Reading Undefined Size Attribute on Disks #48

Closed ericwang401 closed 7 months ago

ericwang401 commented 8 months ago

Background

In Proxmox, disks can be mounted without any media attached, and this results in a disk without any "size" attribute. For example, you can mount an IDE CD/DVD drive without any media and that would have no size attribute.

By default, Convoy assumes every disk has a size attribute. This works for Convoy's official images, but can be problematic for users' custom images if they aren't aware of this bug.

Proposed fix

Give disks without the size attribute a default size of 0.

ericwang401 commented 7 months ago

Resolved in 9cb2cf0da0d0056a72d7efaee5769c7647c682fa.

Will be pushed in v4 release.