search

Cookie-AutoDelete / Cookie-AutoDelete

Firefox and Chrome WebExtension that deletes cookies and other browsing site data as soon as the tab closes, domain changes, browser restarts, or a combination of those events.
MIT License
1.78k stars 113 forks source link

[Bug] Discord cookies are not deleted after enabling local storage cleanup option. #1263

Open ghost opened 2 years ago

ghost commented 2 years ago

Acknowledgements

Describe the bug

  1. Go to discord.com and make a account and login
  2. Close the tab and again go to discord.com
  3. Click on the login button and it will automatically detect your account.

To Reproduce

Same as Describe the bug

Expected Behavior

I expected that discord wouldn't recognize my old account.

Screenshots

No response

System Info - Operating System (OS)

Arch Linux linux 5.14.16.arch1-1

System Info - Browser Info

Firefox 94.0.1 (x64) latest

System Info - CookieAutoDelete Version

3.6.0

Additional Context

No response

kennethtran93 commented 2 years ago

What is your Firefox privacy setting at?

What browsing data types have you enabled for cleanup?

ghost commented 2 years ago

What is your Firefox privacy setting at?

What browsing data types have you enabled for cleanup?

I have hardened my firefox for privacy. I use arkenfox user.js - https://github.com/arkenfox/user.js/ and I have enabled all the options for cleaup in cookie auto delete extension for maximum privacy. image

ghost commented 2 years ago

This is my CAD settings .json file - { "settings": [ { "name": "activeMode", "value": true }, { "name": "cacheCleanup", "value": true }, { "name": "cleanCookiesFromOpenTabsOnStartup", "value": true }, { "name": "cleanExpiredCookies", "value": true }, { "name": "contextMenus", "value": true }, { "name": "contextualIdentities", "value": false }, { "name": "contextualIdentitiesAutoRemove", "value": true }, { "name": "debugMode", "value": true }, { "name": "delayBeforeClean", "value": 5 }, { "name": "discardedCleanup", "value": true }, { "name": "domainChangeCleanup", "value": true }, { "name": "enableGreyListCleanup", "value": true }, { "name": "enableNewVersionPopup", "value": false }, { "id": "DEPRECATED - use default expressions", "name": "greyCleanLocalstorage", "value": false }, { "name": "indexedDBCleanup", "value": true }, { "name": "keepDefaultIcon", "value": false }, { "id": "DEPRECATED - use localStorageCleanup", "name": "localstorageCleanup", "value": true }, { "name": "localStorageCleanup", "value": true }, { "name": "manualNotifications", "value": false }, { "name": "notificationOnScreen", "value": 3 }, { "name": "pluginDataCleanup", "value": true }, { "name": "serviceWorkersCleanup", "value": true }, { "name": "showNotificationAfterCleanup", "value": false }, { "name": "showNumOfCookiesInIcon", "value": true }, { "name": "sizePopup", "value": 16 }, { "name": "sizeSetting", "value": 16 }, { "name": "statLogging", "value": false }, { "id": "DEPRECATED - use default expressions", "name": "whiteCleanLocalstorage", "value": false } ] }

kennethtran93 commented 2 years ago

Are you using containers / contextual identities (No Container, Personal, etc)? If I read the privacy configurations properly, it enables containers. If you are using containers, you'll need to enable the containers setting in CAD, otherwise we only clean up items in the no containers group.

Also from what you linked, it appears to block all third-party cookies, which should be fine. As long as it is not the dynamic state partitioning (cookieBehaviour = 5) or cross-site cookies.

I'm presuming that you waited for at least 5 seconds / CAD notification before opening it up again, per your configuration.

ghost commented 2 years ago

Are you using containers / contextual identities (No Container, Personal, etc)? If I read the privacy configurations properly, it enables containers. If you are using containers, you'll need to enable the containers setting in CAD, otherwise we only clean up items in the no containers group.

Also from what you linked, it appears to block all third-party cookies, which should be fine. As long as it is not the dynamic state partitioning (cookieBehaviour = 5) or cross-site cookies.

I'm presuming that you waited for at least 5 seconds / CAD notification before opening it up again, per your configuration.

I enabled container setting in CAD but still it is not working. Discord cookies are not getting deleted. It is working fine with other sites. Disabling the container still doesn't work. image

kennethtran93 commented 2 years ago

Apologies for the delay in responding. As I don't use the arkenfox user.js configuration, it will take me some time to look into this, and will continue to do so after getting some other bugfixes resolved first.

ghost commented 2 years ago

No problem. Take ur time :)

ItsOnlyBinary commented 2 years ago

I think im having a similar issue to this with ebay.co.uk, after closing ebay.co.uk i get notifications for 3 domains i have whitelisted to allow 1/2 cookies but not all (just auth cookies) but no data is actually cleared for ebay.co.uk

ebay.co.uk has no whitelist or greylist item and is in a normal tab, just restarted my browser and tested with only ebay.co.uk tab and never get the notification or log entry of it closing, appears the issue maybe somewhere in tab closing detection

ghost commented 2 years ago

I think im having a similar issue to this with ebay.co.uk, after closing ebay.co.uk i get notifications for 3 domains i have whitelisted to allow 1/2 cookies but not all (just auth cookies) but no data is actually cleared for ebay.co.uk

ebay.co.uk has no whitelist or greylist item and is in a normal tab, just restarted my browser and tested with only ebay.co.uk tab and never get the notification or log entry of it closing, appears the issue maybe somewhere in tab closing detection

Yes exactly I am getting a lot of websites where auto cookie delete is not able to delete the cookies properly. So basically u can sign in to that website easily without logging in. :(

kennethtran93 commented 2 years ago

@ItsOnlyBinary @prorounak2005 what browser are you using?

ghost commented 2 years ago

@ItsOnlyBinary @prorounak2005 what browser are you using?

I am using firefox. I am using arch linux so I have the bleeding edge firefox installed on arch.

ItsOnlyBinary commented 2 years ago

Firefox Win10

It does seem some what intermittent as i have two computers with a copy of the same firefox profile, and one was cleaning ebay.co.uk ok and the other was not

kennethtran93 commented 2 years ago

Ah if you also have the cross-site cookie option/strict enabled, I am still working on updating the webextension to clean those as well.

ghost commented 2 years ago

Ah if you also have the cross-site cookie option/strict enabled, I am still working on updating the webextension to clean those as well.

Actually I couldn't find the cross site cookie option in the webextension but In firefox it is set to strict.

image

kennethtran93 commented 2 years ago

Ah if you also have the cross-site cookie option/strict enabled, I am still working on updating the webextension to clean those as well.

Actually I couldn't find the cross site cookie option in the webextension but In firefox it is set to strict.

image

Cross-site cookie is the all third-party cookies option as well (same as strict mode).

What you may be experiencing is already noted - this is a work in progress. See #807.